feat: add support for local PVC cleanup during upgrade and rolling restart [KO-427] #374
+584
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abhishekdwivedi3060
commented
May 16, 2025
abhishekdwivedi3060
commented
- Added support for local PVC cleanup during upgrade and rolling restart
- Added test-cases
tanmayja
reviewed
May 20, 2025
tanmayja
reviewed
May 20, 2025
abhishekdwivedi3060
force-pushed
the
feature/KO-427-local-pvc-cleanup
branch
from
108b738 to
0d87a9e
Compare
tanmayja
previously approved these changes
May 29, 2025
sud82
previously approved these changes
Jun 16, 2025
internal/webhook/v1/storage.go
Outdated
| @@ -217,6 +217,12 @@ func getAerospikeStorageList(storage *asdbv1.AerospikeStorageSpec, onlyPV bool) | |||
| func validateStorage( | |||
| storage *asdbv1.AerospikeStorageSpec, podSpec *asdbv1.AerospikePodSpec, | |||
| ) error { | |||
| if asdbv1.GetBool(storage.DeleteLocalStorageOnRestart) && len(storage.LocalStorageClasses) == 0 { | |||
| return fmt.Errorf( | |||
| "deleteLocalStorageOnRestart is set to true, but no local storage classes are defined", | |||
There was a problem hiding this comment.
Replace local storage classes with localStorageClasses
-> localStorageClasses cannot be empty if deleteLocalStorageOnRestart is set.
…delay [KO-427] (#383) * feat: optimise rolling-restart and upgrade flow with dynamic MFD [KO-427]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.