Skip to content

Conversation

reugn
Copy link
Member

@reugn reugn commented Oct 17, 2025

The main issue was checking the wrong error in sindex_writer.go.

@reugn reugn requested a review from filkeith October 17, 2025 08:06
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 62.16216% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.82%. Comparing base (b515ffe) to head (4035c7c).

Files with missing lines Patch % Lines
io/aerospike/sindex_writer.go 68.00% 8 Missing ⚠️
io/storage/aws/s3/writer.go 0.00% 2 Missing and 2 partials ⚠️
io/storage/azure/blob/reader.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   78.73%   78.82%   +0.09%     
==========================================
  Files         105      105              
  Lines       10533    10533              
==========================================
+ Hits         8293     8303      +10     
+ Misses       1745     1735      -10     
  Partials      495      495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@filkeith filkeith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reugn reugn merged commit eb11c54 into main Oct 19, 2025
14 checks passed
@reugn reugn deleted the enhance-error-handling branch October 19, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants