Skip to content

add fee to transaction #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
thepiwo opened this issue Oct 23, 2017 · 0 comments · Fixed by #101
Closed
3 tasks done

add fee to transaction #83

thepiwo opened this issue Oct 23, 2017 · 0 comments · Fixed by #101
Assignees
@cheezus1

Comments

@thepiwo
Copy link
Collaborator

thepiwo commented Oct 23, 2017 •
edited by cheezus1
Loading

  • add fee value to the transaction
  • the fee will should be reduced from from_acc e.g. balance 100 --> from_acc 99 fee 1
  • the miner should be able to collect all fees from transactions in the block in addition to the coinbase
@cheezus1 cheezus1 self-assigned this Oct 25, 2017
cheezus1 pushed a commit that referenced this issue Oct 30, 2017
[GH-#83] Added fee to transactions
53f40ab
@cheezus1 cheezus1 mentioned this issue Oct 30, 2017
Merged
cheezus1 pushed a commit that referenced this issue Oct 31, 2017
[GH-#83] Small refactoring
0fe9aad
cheezus1 pushed a commit that referenced this issue Nov 1, 2017
[GH-#83] Fees are now added to the coinbase transaction
e3212cb
cheezus1 pushed a commit that referenced this issue Nov 1, 2017
[GH-#83] Added test
dd98470
cheezus1 pushed a commit that referenced this issue Nov 3, 2017
[GH-#83] Fixed test
741239f
cheezus1 pushed a commit that referenced this issue Nov 3, 2017
[GH-#83] Fixed conflicts
16ec2e8
cheezus1 pushed a commit that referenced this issue Nov 3, 2017
[GH-#83] Fixed sum_coinbase_transactions
e0bd001
cheezus1 pushed a commit that referenced this issue Nov 3, 2017
[GH-#83] Fixed coinbase tx fee
e9d35fe
andonov added a commit that referenced this issue Nov 3, 2017
@andonov
Merge pull request #101 from aeternity/GH-83
56c8a5d 
[GH-#83] Added fee to transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheezus1 cheezus1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-#83] Added fee to transactions aeternity/elixir-node
2 participants
@cheezus1 @thepiwo