GH-68 Broadcasting new transactions to other peers #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepiwo
reviewed
Oct 25, 2017
| case direction do | ||
| :serialize -> | ||
| tx | ||
| |> :erlang.term_to_binary() |
There was a problem hiding this comment.
like this all of the transaction will be a base64 string, only the binary fields should be handled like this, so a readable json format is used. See the Serialize.block() function.
thepiwo
reviewed
Oct 25, 2017
apps/aehttpclient/lib/client.ex
Outdated
| Send newest transactions to a peer | ||
| """ | ||
| @spec broadcast_tx(String.t, map()) :: {:ok, map()} | {:error, term()} | ||
| def broadcast_tx(uri, tx) do |
thepiwo
approved these changes
Oct 27, 2017
andonov
approved these changes
Oct 27, 2017
meivantodorov
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68