fix: return 404 in case Admin Registration Status is not WAITING

Author: İdil Zeynep Alemdar

src/main/java/org/ays/auth/service/impl/AdminRegistrationCompleteServiceImpl.java

@@ -1,9 +1,11 @@
 package org.ays.auth.service.impl;
 
+import java.util.List;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.collections4.CollectionUtils;
 import org.ays.auth.exception.AysAdminRegistrationApplicationNotExistByIdAuthException;
+import org.ays.auth.exception.AysAdminRegistrationApplicationNotExistByIdException;
 import org.ays.auth.exception.AysUserAlreadyExistsByEmailAddressException;
 import org.ays.auth.exception.AysUserAlreadyExistsByPhoneNumberException;
 import org.ays.auth.model.AdminRegistrationApplication;
@@ -26,8 +28,6 @@
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
-import java.util.List;
-
 /**
  * Implementation of {@link AdminRegistrationCompleteService} that handles the completion of admin registration applications.
  * This service manages the creation of new admin users and assigns appropriate roles and permissions.
@@ -83,7 +83,7 @@ public void complete(final String id, final AdminRegistrationApplicationComplete
         final AdminRegistrationApplication application = adminRegistrationApplicationReadPort
                 .findById(id)
                 .filter(AdminRegistrationApplication::isWaiting)
-                .orElseThrow(() -> new AysAdminRegistrationApplicationNotExistByIdAuthException(id));
+                .orElseThrow(() -> new AysAdminRegistrationApplicationNotExistByIdException(id));
 
         user.setInstitution(application.getInstitution());
         user.notVerify();

src/test/java/org/ays/auth/controller/AdminRegistrationApplicationControllerTest.java

@@ -2,6 +2,7 @@
 
 import org.ays.AysRestControllerTest;
 import org.ays.auth.exception.AysAdminRegistrationApplicationNotExistByIdAuthException;
+import org.ays.auth.exception.AysAdminRegistrationApplicationNotExistByIdException;
 import org.ays.auth.model.AdminRegistrationApplication;
 import org.ays.auth.model.AdminRegistrationApplicationBuilder;
 import org.ays.auth.model.enums.AdminRegistrationApplicationStatus;
@@ -399,7 +400,7 @@ void givenIdAndAdminRegisterRequest_whenAdminApplicationNotFound_thenReturnUnaut
                 .withValidValues().build();
 
         // When
-        Mockito.doThrow(new AysAdminRegistrationApplicationNotExistByIdAuthException(mockId))
+        Mockito.doThrow(new AysAdminRegistrationApplicationNotExistByIdException(mockId))
                 .when(adminRegistrationCompleteService)
                 .complete(Mockito.anyString(), Mockito.any());