Skip to content

Commit 80fd3ee

Browse files
committed
AYS-427 | Usages of UUID.randomUUID().toString() Have Been Changed as Hard Codded UUID in AdminRegistrationApplicationServiceImplTest Class
1 parent 20ae879 commit 80fd3ee

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

src/test/java/org/ays/auth/service/impl/AdminRegistrationApplicationServiceImplTest.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.ays.common.model.AysPage;
2626
import org.ays.common.model.AysPageBuilder;
2727
import org.ays.common.model.AysPageable;
28-
import org.ays.common.util.AysRandomUtil;
2928
import org.ays.institution.model.Institution;
3029
import org.ays.institution.model.InstitutionBuilder;
3130
import org.ays.institution.port.InstitutionReadPort;
@@ -154,7 +153,7 @@ void givenAdminUserRegisterApplicationId_whenGettingAdminUserRegisterApplication
154153
void givenAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationNotFound_thenThrowAysAdminUserRegisterApplicationNotExistByIdException() {
155154

156155
// Given
157-
String mockId = AysRandomUtil.generateUUID();
156+
String mockId = "608484c9-4fec-46da-9515-3341817e4843";
158157

159158
// When
160159
Mockito.when(adminRegistrationApplicationReadPort.findById(mockId))
@@ -175,7 +174,7 @@ void givenAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationNotFoun
175174
void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationFoundWithWaitingStatus_thenReturnAdminUserRegisterApplication() {
176175

177176
// Given
178-
String mockId = AysRandomUtil.generateUUID();
177+
String mockId = "43af258d-d177-4227-9246-aef772609095";
179178
AdminRegistrationApplication mockApplication = new AdminRegistrationApplicationBuilder()
180179
.withValidValues()
181180
.withId(mockId)
@@ -206,7 +205,7 @@ void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationFo
206205
void givenValidAdminUserRegisterApplicationId_whenThereIsNoAdminUserRegisterApplicationWithWaitingStatus_thenThrowAdminRegistrationApplicationNotExistException() {
207206

208207
// Given
209-
String mockId = AysRandomUtil.generateUUID();
208+
String mockId = "9f863805-ee46-44f8-9354-4cd49e21bfea";
210209

211210
// When
212211
Mockito.when(adminRegistrationApplicationReadPort.findById(mockId))
@@ -286,7 +285,7 @@ void givenInvalidInstitutionId_whenCreatingAdminUserRegisterApplication_thenThro
286285
void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationApproved_thenReturnNothing() {
287286

288287
// Given
289-
String mockId = AysRandomUtil.generateUUID();
288+
String mockId = "6957a570-2ffe-4409-b4c5-5597f7ecfc15";
290289
AysUser mockUser = new AysUserBuilder()
291290
.withValidValues()
292291
.withStatus(AysUserStatus.NOT_VERIFIED)
@@ -322,7 +321,7 @@ void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationAp
322321
void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationNotFound_thenThrowAdminRegistrationApplicationNotExistByIdException() {
323322

324323
// Given
325-
String mockId = AysRandomUtil.generateUUID();
324+
String mockId = "ba88600d-c38f-4a37-99be-2e4f26f00fc9";
326325

327326
// When
328327
Mockito.when(adminRegistrationApplicationReadPort.findById(mockId))
@@ -350,7 +349,7 @@ void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationNo
350349
void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationWaiting_thenThrowAysAdminRegistrationApplicationInCompleteException() {
351350

352351
// Given
353-
String mockId = AysRandomUtil.generateUUID();
352+
String mockId = "c77ed397-16b1-4310-9644-eb2a51be2e86";
354353
AdminRegistrationApplication mockApplication = new AdminRegistrationApplicationBuilder()
355354
.withValidValues()
356355
.withStatus(AdminRegistrationApplicationStatus.WAITING)
@@ -381,7 +380,7 @@ void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationWa
381380
void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationApproved_thenThrowAysAdminRegistrationApplicationAlreadyApprovedException() {
382381

383382
// Given
384-
String mockId = AysRandomUtil.generateUUID();
383+
String mockId = "85d61489-8c78-4d03-a8ea-98154fc6ceb0";
385384
AdminRegistrationApplication mockApplication = new AdminRegistrationApplicationBuilder()
386385
.withValidValues()
387386
.withStatus(AdminRegistrationApplicationStatus.APPROVED)
@@ -412,7 +411,7 @@ void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationAp
412411
void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationRejected_thenThrowAysAdminRegistrationApplicationAlreadyRejectedException() {
413412

414413
// Given
415-
String mockId = AysRandomUtil.generateUUID();
414+
String mockId = "773ba2c1-760f-4e4b-a1cb-0f5994291e73";
416415
AdminRegistrationApplication mockApplication = new AdminRegistrationApplicationBuilder()
417416
.withValidValues()
418417
.withStatus(AdminRegistrationApplicationStatus.REJECTED)
@@ -443,7 +442,7 @@ void givenValidAdminUserRegisterApplicationId_whenAdminUserRegisterApplicationRe
443442
void givenAdminUserRegisterApplicationIdAndAdminUserRegisterApplicationRejectRequest_whenRejectingAdminUserRegisterApplication_thenReturnNothing() {
444443

445444
// Given
446-
String mockId = AysRandomUtil.generateUUID();
445+
String mockId = "6eae8d93-aa8a-4520-b20b-600840ef893d";
447446
AysUser mockUser = new AysUserBuilder()
448447
.withValidValues()
449448
.withStatus(AysUserStatus.NOT_VERIFIED)
@@ -479,7 +478,7 @@ void givenAdminUserRegisterApplicationIdAndAdminUserRegisterApplicationRejectReq
479478
void givenAdminUserRegisterApplicationIdAndAdminUserRegisterApplicationRejectRequest_whenAdminUserRegisterApplicationNotFound_thenThrowAysAdminUserRegisterApplicationNotExistByIdAndStatusException() {
480479

481480
// Given
482-
String mockId = AysRandomUtil.generateUUID();
481+
String mockId = "cd52e3f0-b57b-453a-bd35-57c55d32fd0e";
483482
AdminRegistrationApplicationRejectRequest mockRequest = new AdminRegistrationApplicationRejectRequestBuilder()
484483
.withValidValues()
485484
.build();
@@ -509,7 +508,7 @@ void givenAdminUserRegisterApplicationIdAndAdminUserRegisterApplicationRejectReq
509508
void givenAdminUserRegisterApplicationIdAndAdminUserRegisterApplicationRejectRequest_whenAdminUserRegisterApplicationIsNotCompleted_thenThrowAysAdminUserRegisterApplicationNotExistByIdAndStatusException() {
510509

511510
// Given
512-
String mockId = AysRandomUtil.generateUUID();
511+
String mockId = "cf8f8e6b-4255-4407-94d2-cdf612888e20";
513512
AysUser mockUser = new AysUserBuilder()
514513
.withValidValues()
515514
.withStatus(AysUserStatus.NOT_VERIFIED)

0 commit comments

Comments
 (0)