Skip to content

Conversation

alpemreelmas
Copy link
Contributor

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

@agitrubard
Copy link
Collaborator

@alpemreelmas bütün arkadaşları reviewer olarka ekleyebilir miyiz?

Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Başlıkta yazan Kiness ifadesi yerine Kinesis yazabilir miyiz? Ek olarak DynamoDB entegrasyonunun da kaldırıldığını başlıkta belirtmemiz faydalı olur. Ya da DynamoDB entegrasyonunun Kinesis ile değiştirildiğini söyleyebiliriz.

@alpemreelmas alpemreelmas changed the title AYS-508 | Kiness Integration AYS-508 | Kinesis Integration Nov 23, 2024
@alpemreelmas alpemreelmas changed the title AYS-508 | Kinesis Integration AYS-508 | Kinesis Integration & Removed DynamoDB Integration Nov 23, 2024
@agitrubard agitrubard merged commit 9795353 into main Nov 24, 2024
3 checks passed
@agitrubard agitrubard deleted the AYS-508/Kiness-Integration branch November 24, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants