Skip to content

AYS-550 | NoSpecialCharacterValidator Have Been Updated to Prevent Strings from Starting or Ending With Spaces #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2024
Merged

AYS-550 | NoSpecialCharacterValidator Have Been Updated to Prevent Strings from Starting or Ending With Spaces #402

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3be55f
AYS-550 | `NoSpecialCharacterValidator` Have Been Updated to Prevent …
egehanasal Nov 19, 2024
499a8c5
AYS-550 | Tests Have Been Fixed
egehanasal Nov 19, 2024
5ecbbdc
AYS-550 | Tests Have Been Updated For `NoSpecialCharacters`
egehanasal Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/org/ays/common/util/validation/NoSpecialCharacterValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,15 @@ public boolean isValid(String value, ConstraintValidatorContext constraintValida
return true;
}

boolean startsOrEndsWithSpace = value.matches("^\\s.*|.*\\s$");

if (startsOrEndsWithSpace) {
constraintValidatorContext.disableDefaultConstraintViolation();
constraintValidatorContext.buildConstraintViolationWithTemplate("cannot starts or ends with space")
.addConstraintViolation();
return false;
}

boolean containsOnlyDigits = value.matches("^\\d+$");

if (containsOnlyDigits) {
Expand Down
5 changes: 4 additions & 1 deletion src/test/java/org/ays/auth/controller/AdminRegistrationApplicationControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ void givenValidAdminRegisterApplicationId_whenUnauthorizedForGettingAdminRegiste
"This is a valid text with sufficient length and contains alphabetic characters.",
"This text includes numbers 12345 and still should be accepted because it's within limits.",
"This text, which includes punctuation marks, should be accepted.",
" This text has leading and trailing spaces which should be trimmed and accepted. ",
"ÇalıŞkan ve dÜrüst İnsanlar her zaman başarıyı yakalar.(:;?/)"
})
void givenValidAdminRegisterApplicationCreateRequest_whenCreatingAdminRegisterApplication_thenReturnAdminRegisterApplicationCreateResponse(String reason) throws Exception {
Expand Down Expand Up @@ -248,6 +247,10 @@ void givenValidAdminRegisterApplicationCreateRequest_whenCreatingAdminRegisterAp
".,..,.,.,.,.,,.,.,.,.,.,.,.,.,..,.,.,,.,.,.,",
"Too short",
" a",
" spaceAtTheBeginning",
"spaceAtTheEnd ",
" both ",
" justAString ",
"151201485621548562154851458614125461254125412",
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean vestibulum commodo turpis, sed venenatis sapien suscipit sit amet. Etiam malesuada, ligula in semper varius, nisi mi pulvinar libero, ut commodo dolor orci quis urna. Vivamus ac euismod ex. Proin vel vulputate orci. Ut id nibh finibus, mattis sem id, maximus ante. Proin fringilla ipsum at arcu venenatis, non bibendum justo luctus. Phasellus vestibulum feugiat est sit amet bibendum. Donec nulla leo, ultricies sed pharetra sed, hendrerit vel nunc."
})
Expand Down