Skip to content

Conversation

sanshigo345
Copy link
Collaborator

@sanshigo345 sanshigo345 commented Aug 8, 2024

Checklist

Before submitting your pull request, ensure the following:

  • Change Type:

  • Bug fix

  • Feature addition

  • Documentation update

  • Performance improvement

  • Other (please specify)

  • Summary:

    • Added role listing page
  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on my browser, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by ESLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.

    • Assignees have been added if necessary.

    • Related Issue:

    • Closes #AYS-345 (If there is a relevant issue)

  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

@sanshigo345 sanshigo345 requested a review from kevseroz as a code owner August 8, 2024 11:09
@agitrubard
Copy link
Contributor

@sanshigo345 Selamlar,
Pull Request başlığını düzenleyebilir miyiz?

Ek olarak Draft'a almak için başlığa yazmak yerine GitHub'ın kendi özelliğini kullanabilir miyiz?
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft

@sanshigo345 sanshigo345 marked this pull request as draft August 8, 2024 11:27
@sanshigo345 sanshigo345 changed the title (DRAFT) - Feature/ays 298/role listing page AYS-298 | Role Listing Page Aug 9, 2024
@sanshigo345 sanshigo345 marked this pull request as ready for review August 9, 2024 15:48
@sanshigo345 sanshigo345 merged commit 0473a4a into main Aug 10, 2024
1 check passed
@sanshigo345 sanshigo345 deleted the feature/AYS-298/Role-Listing-Page branch August 10, 2024 12:00
sanshigo345 added a commit that referenced this pull request Aug 10, 2024
@sanshigo345 sanshigo345 self-assigned this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants