Skip to content

Conversation

sanshigo345
Copy link
Collaborator

Checklist

Before submitting your pull request, ensure the following:

  • Change Type:

  • Bug fix

  • Feature addition

  • Documentation update

  • Performance improvement

  • Other (please specify)

  • Summary:

    • add validation to check phone line number to be 10 digits
  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on my browser, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by ESLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Related Issue:

    • Closes #AYS-504 (If there is a relevant issue)
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

@sanshigo345 sanshigo345 requested a review from sharp3614 October 16, 2024 16:39
@sanshigo345 sanshigo345 self-assigned this Oct 16, 2024
@sanshigo345 sanshigo345 requested a review from NNakreSS as a code owner October 16, 2024 16:39
NNakreSS
NNakreSS previously approved these changes Oct 17, 2024
@sanshigo345 sanshigo345 merged commit 527614f into main Oct 21, 2024
1 check passed
@sanshigo345 sanshigo345 deleted the feature/AYS-504/phone-format-validation-in-emergency-forms branch October 21, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants