Skip to content

Conversation

plnknr
Copy link
Contributor

@plnknr plnknr commented Dec 22, 2024

Checklist

Before submitting your pull request, ensure the following:

  • Change Type:

  • Bug fix

  • Feature addition

  • Documentation update

  • Performance improvement

  • Other (please specify)

  • Summary:

    • SonarQube integration
  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on my browser, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by ESLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Related Issue:

    • Closes #AYS-573
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

@plnknr plnknr requested a review from sanshigo345 as a code owner December 22, 2024 17:35
@plnknr plnknr changed the title AYS-573 | SonarQube-Integration-fe-landing AYS-573 | SonarQube-Integration-fe-landing-fe Dec 22, 2024
@plnknr plnknr changed the title AYS-573 | SonarQube-Integration-fe-landing-fe AYS-573 | SonarQube-Integration-fe-landing-f Dec 22, 2024
@sanshigo345 sanshigo345 changed the title AYS-573 | SonarQube-Integration-fe-landing-f AYS-573 | SonarQube Integration Dec 22, 2024
@sanshigo345 sanshigo345 merged commit cb6d475 into main Dec 22, 2024
4 checks passed
@sanshigo345 sanshigo345 deleted the feature/AYS-573/SonarQube-Integration-fe-landing branch December 22, 2024 18:03
# - uses: sonarsource/sonarqube-quality-gate-action@master
# timeout-minutes: 5
# env:
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanshigo345 @plnknr burayı kullanmamız gerekmiyor mu? Quality Gate!e göre hareket etmesini sağlamamız gerekiyor diye düşünüyorum

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bu PR ile sadece sonarqube integrationı yapıldı diye biliyorum. daha detaylı bilgiye @plnknr @yusufkaya01 sahiptir diye düşünüyorum.

# - uses: sonarsource/sonarqube-quality-gate-action@master
# timeout-minutes: 5
# env:
# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanshigo345 @plnknr burayı kullanmamız gerekmiyor mu? Quality Gate!e göre hareket etmesini sağlamamız gerekiyor diye düşünüyorum

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bu PR ile sadece sonarqube integrationı yapıldı diye biliyorum. daha detaylı bilgiye @plnknr @yusufkaya01 sahiptir diye düşünüyorum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants