Merge pull request #4 from aftermath2/fix_age_calculation

Fix age calculation

Author: aftermath2

policy/node.go

@@ -58,8 +58,8 @@ func (n *Node) checkAge(bestBlockHeight uint32, channels []*lnrpc.ChannelEdge) b
 		}
 	}
 
-	difference := bestBlockHeight - oldestChannel
-	return n.Age.Contains(difference)
+	age := (bestBlockHeight - oldestChannel) + 1
+	return n.Age.Contains(age)
 }
 
 func (n *Node) checkHybrid(addresses []*lnrpc.NodeAddress) bool {

policy/node_test.go

@@ -115,6 +115,7 @@ func TestEvaluateNode(t *testing.T) {
 func TestCheckAge(t *testing.T) {
 	bestBlockHeight := uint32(820931)
 	one := uint32(1)
+	two := uint32(2)
 
 	cases := []struct {
 		desc     string
@@ -136,7 +137,7 @@ func TestCheckAge(t *testing.T) {
 		{
 			desc: "Min no match",
 			age: &Range[uint32]{
-				Min: &one,
+				Min: &two,
 			},
 			channels: []*lnrpc.ChannelEdge{
 				{ChannelId: 902623180101779456}, // 820931
@@ -149,7 +150,6 @@ func TestCheckAge(t *testing.T) {
 				Max: &one,
 			},
 			channels: []*lnrpc.ChannelEdge{
-				{ChannelId: 902622080590151680}, // 820930
 				{ChannelId: 902623180101779456}, // 820931
 			},
 			expected: true,
@@ -165,6 +165,18 @@ func TestCheckAge(t *testing.T) {
 			},
 			expected: false,
 		},
+		{
+			desc: "Range",
+			age: &Range[uint32]{
+				Min: &one,
+				Max: &two,
+			},
+			channels: []*lnrpc.ChannelEdge{
+				{ChannelId: 902622080590151680}, // 820930
+				{ChannelId: 902623180101779456}, // 820931
+			},
+			expected: true,
+		},
 		{
 			desc: "No channels min",
 			age: &Range[uint32]{