-
Notifications
You must be signed in to change notification settings - Fork 251
Ring reasoning #2765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Ring reasoning #2765
Conversation
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Need to build on it.
…of a Ring, properly renamed.
|
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating my nitpick suggestions.
Guessing that this PR hints that we should perhaps also have/need the intermediate extension to |
Yes, there is quite a lot that can be done in this vein. We should be careful not to have perfect be the enemy of definite-improvement... |
Yeah, not my intention at all to obstruct this PR with demands for more here... but elsewhere, in due course, definitely! |
I guess, strictly speaking, neither you nor @Taneb are blocking this on requiring more features... |
Absolutely not blocking from me! but... maybe a rebase against the new |
That's why it's Draft, I need to do at least those changes. |
Reasoning combinators for monoid, renamed and adapted for Ring. Builds on #2692 .