Skip to content

Ring reasoning #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 50 commits into
base: master
Choose a base branch
from
Draft

Ring reasoning #2765

wants to merge 50 commits into from

Conversation

JacquesCarette
Copy link
Contributor

Reasoning combinators for monoid, renamed and adapted for Ring. Builds on #2692 .

jmougeot and others added 12 commits July 3, 2025 16:06
@Taneb
Copy link
Member

Taneb commented Jul 12, 2025

  1. I'd like to see the new semigroup properties here as well
  2. The semigroup properties on * and the monoid properties on + work for RingWithoutOne
  3. In fact, they work on Semiring and SemiringWithoutOne, but we don't have a Properties module for those

@jamesmckinna
Copy link
Contributor

@Taneb 's 1,2,3 above echo my thoughts on looking at these, but maybe, given our ongoing issues regarding naming in #2688 that it isn't so straightforward to back-fill the Properties for weaker structures... yet?

JacquesCarette and others added 2 commits July 21, 2025 17:11
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
@JacquesCarette JacquesCarette marked this pull request as draft July 21, 2025 21:12
@JacquesCarette JacquesCarette added this to the v2.4 milestone Jul 21, 2025
Copy link
Contributor

@jamesmckinna jamesmckinna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating my nitpick suggestions.

@jamesmckinna
Copy link
Contributor

Guessing that this PR hints that we should perhaps also have/need the intermediate extension to Algebra.Properties.(Abelian)Group to incorporate inverse equational simplification for the +-abelianGroup sub-structure/-bundle... as a downstream PR.

@JacquesCarette
Copy link
Contributor Author

Yes, there is quite a lot that can be done in this vein.

We should be careful not to have perfect be the enemy of definite-improvement...

@jamesmckinna
Copy link
Contributor

Yes, there is quite a lot that can be done in this vein.

We should be careful not to have perfect be the enemy of definite-improvement...

Yeah, not my intention at all to obstruct this PR with demands for more here... but elsewhere, in due course, definitely!

@JacquesCarette
Copy link
Contributor Author

I guess, strictly speaking, neither you nor @Taneb are blocking this on requiring more features...

@jamesmckinna
Copy link
Contributor

Absolutely not blocking from me!

but... maybe a rebase against the new master to sort out the CHANGELOG conflict, and to catch the already-merged Semigroup commits (I think the Monoid PR I still open though...?)?

@JacquesCarette
Copy link
Contributor Author

That's why it's Draft, I need to do at least those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants