Skip to content

[ refactor ] make m ≤ n argument to Data.Vec.Base.{truncate|padRight} irrelevant #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[ refactor ] make m ≤ n argument to Data.Vec.Base.{truncate|padRight} irrelevant #2787

wants to merge 5 commits into from
+115 −41

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Jul 27, 2025 •
edited
Loading

Tackles #2770
Blocked on #2769 and #2795 , but could be merged into that PR instead.
Refactored Properties to take advantage of the revised definition(s), and the new properties.

@jamesmckinna jamesmckinna added this to the v2.4 milestone Jul 27, 2025
@jamesmckinna jamesmckinna added status: blocked-by-issue Progress on this issue or PR is blocked by another issue. refactoring labels Jul 27, 2025
@jamesmckinna jamesmckinna linked an issue Jul 27, 2025 that may be closed by this pull request
[ refactor ] change type of Data.Vec.Base.{truncate|padRight} #2770
Open
@jamesmckinna jamesmckinna mentioned this pull request Jul 27, 2025
Open
@jamesmckinna jamesmckinna changed the title [ refactor ] make Data.Vec.Base.{truncate|padRight} take irrelevant m ≤ n argument [ refactor ] make m ≤ n argument to make Data.Vec.Base.{truncate|padRight} irrelevant Jul 29, 2025
@jamesmckinna jamesmckinna changed the title [ refactor ] make m ≤ n argument to make Data.Vec.Base.{truncate|padRight} irrelevant [ refactor ] make m ≤ n argument to Data.Vec.Base.{truncate|padRight} irrelevant Jul 29, 2025
@jamesmckinna jamesmckinna mentioned this pull request Jul 31, 2025
Open
@jamesmckinna
Copy link
Contributor Author

I've taken the liberty of adding, and then suitably modifying the proofs of, the properties introduced by #2769 and #2795, so as and when those are merged in, I'll fix the merge conflict and rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesCarette JacquesCarette JacquesCarette approved these changes

Assignees
No one assigned
Labels
refactoring status: blocked-by-issue Progress on this issue or PR is blocked by another issue.
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

[ refactor ] change type of Data.Vec.Base.{truncate|padRight}
2 participants
@jamesmckinna @JacquesCarette