Fixes for agda/agda#8533: eta equality is no longer inferred#2986
Merged
andreasabel merged 2 commits intoexperimentalfrom Apr 30, 2026
Merged
Fixes for agda/agda#8533: eta equality is no longer inferred#2986andreasabel merged 2 commits intoexperimentalfrom
andreasabel merged 2 commits intoexperimentalfrom
Conversation
This was referenced Apr 23, 2026
- `Data.Record` needs a `ETA_EQUALITY` pragma to suppress the `UnguardedEtaRecord` warning. - `Reflection.AST.Traversal` needs an explicit declaration of `no-eta-equality`. This was previously inferred.
andreasabel
force-pushed
the
unguarded-eta-record
branch
from
a42481a to
ddd5211
Compare
andreasabel
added a commit
to agda/agda
that referenced
this pull request
Apr 24, 2026
andreasabel
added a commit
to agda/agda
that referenced
this pull request
Apr 28, 2026
* WIP: eta should not be inferred * WIP #8370 #7477 require no-eta-equality to be declared * Cosmetics: rename checkAxiom' to checkAxiom (unused) * WIP: add ETA_EQUALITY pragma replacing ETA * WIP: add forceEta to A.RecDef * WIP: add ETA_EQUALITY pragma to parser * Clean: Lexer.x: remove old CPP conditional * WIP: Remove A.EtaPragma (keep C.EtaPragma) * ETA_EQUALITY: Missing line in Parser.y [Storch] * Update test cases * Address my review comments, add missing tests * Remove SafeFlagEta error * Update documentation * Update std-lib submodule * Update std-lib submodule to agda/agda-stdlib#2986 * Update docs about unguarded records * Address Jesper and my review comments * CHANGELOG
Member
Author
Has landed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data.Recordneeds aETA_EQUALITYpragma to suppress theUnguardedEtaRecordwarning.Reflection.AST.Traversalneeds an explicit declaration ofno-eta-equality.This was previously inferred.
These changes will be needed in
experimentalonce agda/agda#8533 lands.Superseds: