Skip to content

Feat: Browser Control #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Feat: Browser Control #706

wants to merge 1 commit into from

Conversation

TerminallyLazy
Copy link
Contributor

VNC-Based Browser Control Implementation

Summary

  • ✅ Direct VNC Access: Implement "Take over browser" button that opens VNC interface at vnc_lite.html
  • ✅ Environment Variable Authentication: Configure VNC password via VNC_PASSWORD environment variable with secure fallback
  • ✅ Dynamic Password Retrieval: Add API endpoint to fetch current VNC password for user authentication
  • ✅ Docker Integration: Complete supervisord configuration with x11vnc server and password protection
  • ✅ Code Cleanup: Remove unused VNC infrastructure files with comprehensive backup system

Test plan

  • Build and run Docker container with browser control
  • Click "Take over browser" button in UI
  • Verify VNC password dialog displays correct password
  • Confirm VNC interface opens at http://localhost:56080/vnc_lite.html
  • Test VNC authentication with displayed password
  • Verify browser control functionality through VNC
  • Test custom password via VNC_PASSWORD environment variable
  • Confirm popup blocking fallback works correctly

Technical Implementation

Core Features

  • VNC Integration: Direct integration with x11vnc server via supervisord
  • Password Management: Environment variable-based authentication with API retrieval
  • Web UI Enhancement: Seamless "Take over browser" button integration
  • Error Handling: Comprehensive popup blocking detection and fallback mechanisms

Files Added/Modified

  • docker/run/fs/etc/supervisor/conf.d/supervisord.conf - VNC server configuration
  • docker/docker-compose.browser-control.yml - Environment variable support
  • python/api/browser_control.py - VNC password API endpoint
  • webui/js/messages.js - Enhanced takeControl() function
  • docker/.env.example - Environment configuration template

Files Cleaned Up (Backed up to /backups/)

  • Removed 9 unused VNC infrastructure files
  • Created comprehensive backup system with recovery instructions
  • Generated detailed cleanup report documentation

Security Considerations

  • VNC authentication required via configurable password
  • Environment variable-based password management
  • No hardcoded credentials in source code
  • Secure API endpoint for password retrieval

@TerminallyLazy
feat: implement VNC-based browser control with environment variable …
72907fe 
…authentication

  - Add VNC server integration with configurable password authentication
  - Implement "Take over browser" button with direct VNC interface access
  - Create dynamic password retrieval API endpoint for secure access
  - Update Docker configuration with VNC_PASSWORD environment variable support
  - Add supervisord configuration for x11vnc with password protection
  - Clean up unused VNC infrastructure files and create comprehensive backups
  - Support vnc_lite.html interface for optimal user experience
  - Include fallback popup blocking detection and error handling
@TerminallyLazy TerminallyLazy changed the base branch from main to development August 27, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TerminallyLazy