feat(embedding): add pass_dimensions option to OpenAI embedding#1758
Open
jinliyl wants to merge 3 commits into
Open
feat(embedding): add pass_dimensions option to OpenAI embedding#1758jinliyl wants to merge 3 commits into
jinliyl wants to merge 3 commits into
Conversation
- Added pass_dimensions parameter to control whether dimensions are passed to API - Updated constructor to accept pass_dimensions with default value True - Modified API call to conditionally include dimensions based on pass_dimensions - Implemented proper embedding result mapping by index to handle sparse responses - Updated embedding retrieval and storage to use indexed mapping instead of simple lists - Added fallback to dense_embedding when regular embedding is not available
…bedding handler - Removed redundant None check and list conversion for embedding vectors - Streamlined the embedding assignment to directly use emb.embedding or dense_embedding - Maintained existing caching functionality for stored embeddings - Improved code readability by reducing nested conditional logic
…ponse handling - Changed getattr call to use proper attribute access with fallback - Improved code readability by formatting multi-line attribute access - Maintained existing functionality while enhancing code structure - Applied consistent spacing and formatting for better maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title Format
Please ensure your PR title follows the Conventional Commits format:
<type>(<scope>): <description>feat(memory): add redis cache supportfeat,fix,docs,ci,refactor,test,chore,perf,style,build,revertAgentScope Version
[The version of AgentScope you are working on, e.g.
import agentscope; print(agentscope.__version__)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
pre-commit run --all-filescommand