feat: Adds functionality to provide privacy for sender. python-discord#1477

Adds functionality that instantly deletes messages if "anon" type was specified. Notifications and who is typing will still be sent, but it still provides some anonymity. Also fixes bug that sends the confirmation message to the receiver of the message (should be sender).

Author: agussarsson

bot/exts/holidays/valentines/be_my_valentine.py

@@ -44,7 +44,7 @@ async def lovefest_role(self, ctx: commands.Context) -> None:
     # @commands.cooldown(1, 1800, commands.BucketType.user)
     @commands.group(name="bemyvalentine", invoke_without_command=True)
     async def send_valentine(
-        self, ctx: commands.Context, user: discord.Member, privacy_type: str | None = None, valentine_type: str | None = None
+        self, ctx: commands.Context, user: discord.Member, privacy_type: str | None = None, anon: str | None = None, valentine_type: str | None = None
     ) -> None:
         """
         Send a valentine to a specified user with the lovefest role.
@@ -56,6 +56,24 @@ async def send_valentine(
         example: .bemyvalentine public Iceman Hey I love you, wanna hang around ? (sends the custom message publicly to Iceman)
         NOTE : AVOID TAGGING THE USER MOST OF THE TIMES.JUST TRIM THE '@' when using this command.
         """
+
+
+        if anon.lower() == "anon":
+            # Delete the message containing the command right after it was sent to enforce anonymity.
+            try:
+                await ctx.message.delete()
+            except discord.Forbidden:
+                await ctx.send("I can't delete your message! Please check my permissions.")
+            
+
+        if anon not in ["anon", "signed"]:
+            # Anonymity type wrongfully specified.
+            raise commands.UserInputError(
+                f"Specify if you want the message to be anonymous or not!"
+            )
+
+
+
         if ctx.guild is None:
             # This command should only be used in the server
             raise commands.UserInputError("You are supposed to use this command in the server.")
@@ -81,17 +99,25 @@ async def send_valentine(
         channel = self.bot.get_channel(Channels.sir_lancebot_playground)
         valentine, title = self.valentine_check(valentine_type)
 
-        embed = discord.Embed(
-            title=f"{emoji_1} {title} {user.display_name} {emoji_2}",
-            description=f"{valentine} \n **{emoji_2}From {ctx.author}{emoji_1}**",
-            color=Colours.pink
-        )
-    
+        if anon.lower() == "anon":
+            embed = discord.Embed(
+                title=f"{emoji_1} {title} {user.display_name} {emoji_2}",
+                description=f"{valentine} \n **{emoji_2}From an anonymous admirer{emoji_1}**",
+                color=Colours.pink
+            )
+        
+        else:
+            embed = discord.Embed(
+                title=f"{emoji_1} {title} {user.display_name} {emoji_2}",
+                description=f"{valentine} \n **{emoji_2}From {ctx.author}{emoji_1}**",
+                color=Colours.pink
+            )
+
         if privacy_type.lower() == "private":
             # Send the message privately if "private" was speicified
             try:
                 await user.send(embed=embed)
-                await user.send(f"Your valentine has been **privately** delivered to {user.display_name}!")
+                await ctx.author.send(f"Your valentine has been **privately** delivered to {user.display_name}!")
             except discord.Forbidden:
                 await ctx.send(f"I couldn't send a private message to {user.display_name}. They may have DMs disabled.")
         else: