Feature/FIT-10-Details-Food #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Dart linting, Flutter unit tests, PR title validation, and SonarCloud analysis feat: Add meal details feature with API integration - Implemented MealsRetrofitClient for fetching meal details - Created data source and repository for meal details - Added use case for retrieving meal details - Developed MealDetailsScreen UI with ingredients and nutrient information - Introduced BluredContainer for enhanced UI design - Updated routing to include meal details screen - Added necessary models and DTOs for meal details
- Updated `flutter_lints` to version 6.0.0. - Added `video_player` dependency for video playback functionality. - Introduced `http_mock_adapter` and `mocktail` for improved testing capabilities. - Generated localization keys for error messages and UI strings using `easy_localization`. - Implemented `IngredientBody` and `IngredientItem` widgets for displaying meal ingredients. - Created `MealHeaderVideo` widget to handle video playback with fallback image. - Developed `NutrientBody` and `NutrientInfo` widgets for displaying nutritional information. - Added unit tests for `MealsRetrofitClient`, `MealsRemoteDataSourceImpl`, and related use cases. - Established `MealDetailsCubit` for state management in meal details screen.
- Updated imports in meal_details_screen.dart to point to details_food module. - Refactored ingredient_body.dart, ingredient_item.dart, meal_header_video.dart, nutrient_body.dart, and nutrient_info.dart to use the new details_food module. - Modified meal_details_state.dart and meals_details_cubit.dart to include mealId in the state management. - Created new meal_details_screen.dart, ingredient_body.dart, ingredient_item.dart, meal_header_video.dart, nutrient_body.dart, and nutrient_info.dart files in the details_food module. - Updated tests to reflect changes in state management and imports.
This commit refactors the meal details functionality by moving related files and updating imports from the `meal` domain to the `meals` domain. Specific changes include: - Renamed `lib/domain/meal/entity/meal_details_entity.dart` to `lib/domain/meals/entity/meal_details_entity.dart`. - Renamed `lib/domain/meal/repo/meal_details_repo.dart` to `lib/domain/meals/repo/meal_details_repo.dart`. - Renamed `lib/domain/meal/use_case/meal_details_use_case.dart` to `lib/domain/meals/use_case/meal_details_use_case.dart`. - Updated import paths in various files to reflect the new location of meal details related code. - Adjusted the initial route in `inital_route_function.dart` from `AppRoutes.mealDetailsRoute` to `AppRoutes.loginRoute`. - Updated `AppRoutes.mealDetailsRoute` to `AppRoutes.mealsDetailsRoute`. - Ran `build_runner` to regenerate affected generated files.
PeshoOReda
requested review from
Ahmed-Abdelghany-11,
ahmedelazab1220 and
Ammar720
lib/features/details_food/presentation/view_model/cubit/meals_details_cubit.dart
Outdated
Show resolved
Hide resolved
lib/features/details_food/presentation/view/meal_details_screen.dart
Outdated
Show resolved
Hide resolved
Nobel1893
reviewed
Jun 28, 2025
Nobel1893
suggested changes
Jun 28, 2025
|
the status of those actions doesn't reported because u removed the actions files |
This commit refactors the meal details functionality by moving related files and updating imports from the `meal` domain to the `meals` domain. Specific changes include: - Renamed `lib/domain/meal/entity/meal_details_entity.dart` to `lib/domain/meals/entity/meal_details_entity.dart`. - Renamed `lib/domain/meal/repo/meal_details_repo.dart` to `lib/domain/meals/repo/meal_details_repo.dart`. - Renamed `lib/domain/meal/use_case/meal_details_use_case.dart` to `lib/domain/meals/use_case/meal_details_use_case.dart`. - Updated import paths in various files to reflect the new location of meal details related code. - Adjusted the initial route in `initial_route_function.dart` from `AppRoutes.mealDetailsRoute` to `AppRoutes.loginRoute`. - Updated `AppRoutes.mealDetailsRoute` to `AppRoutes.mealsDetailsRoute`. - Ran `build_runner` to regenerate affected generated files.
This commit refactors the meal details functionality by moving related files and updating imports from the `meal` domain to the `meals` domain. Specific changes include: - Renamed `lib/domain/meal/entity/meal_details_entity.dart` to `lib/domain/meals/entity/meal_details_entity.dart`. - Renamed `lib/domain/meal/repo/meal_details_repo.dart` to `lib/domain/meals/repo/meal_details_repo.dart`. - Renamed `lib/domain/meal/use_case/meal_details_use_case.dart` to `lib/domain/meals/use_case/meal_details_use_case.dart`. - Updated import paths in various files to reflect the new location of meal details related code. - Adjusted the initial route in `initial_route_function.dart` from `AppRoutes.mealDetailsRoute` to `AppRoutes.loginRoute`. - Updated `AppRoutes.mealDetailsRoute` to `AppRoutes.mealsDetailsRoute`. - Ran `build_runner` to regenerate affected generated files.
…g and state management
…-details-food # Conflicts: # assets/translations/ar.json # assets/translations/en.json # lib/core/assets/app_icons.dart # lib/core/utils/constants.dart # lib/core/utils/datasource_excution/api_constants.dart # lib/core/utils/di/di.config.dart # lib/core/utils/l10n/locale_keys.g.dart # lib/core/utils/routes/app_routes.dart # lib/data/meals/api/meals_retrofit_client.dart # lib/data/meals/api/meals_retrofit_client.g.dart # pubspec.lock # pubspec.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the meal details functionality by moving related files and updating imports from the
mealdomain to themealsdomain.Specific changes include:
lib/domain/meal/entity/meal_details_entity.darttolib/domain/meals/entity/meal_details_entity.dart.lib/domain/meal/repo/meal_details_repo.darttolib/domain/meals/repo/meal_details_repo.dart.lib/domain/meal/use_case/meal_details_use_case.darttolib/domain/meals/use_case/meal_details_use_case.dart.inital_route_function.dartfromAppRoutes.mealDetailsRoutetoAppRoutes.loginRoute.AppRoutes.mealDetailsRoutetoAppRoutes.mealsDetailsRoute.build_runnerto regenerate affected generated files.This template ensures that all pull requests adhere to the project's contribution standards. It enforces proper naming conventions, code quality, CI/CD validation, and testing requirements. Following this checklist helps maintain a clean and efficient codebase while ensuring compatibility with JIRA issue tracking.
📌 Pull Request Checklist
✅ General
type/TA-<issue-number>-TaskName.feature/meaningful-name,fix/issue-description, etc.📂 Code Quality
snake_case.dart format .🛠 CI/CD Validation
dart analyze.🚀 Testing
flutter test --coveragehas been run and the results reviewed.📝 Additional Information
🔗 Related JIRA Ticket(s):
TA-<issue-number>📸 Screenshots (if applicable):