Doc: Add StashCalculation explanation to RTD
#6861
Conversation
| .. code-block:: python | ||
|
|
||
| from aiida.common.datastructures import StashMode | ||
| from aiida.orm import load_node |
There was a problem hiding this comment.
| from aiida.orm import load_node | |
| from aiida.orm import load_node, load_computer |
|
|
||
| inputs = { | ||
| 'metadata': { | ||
| 'computer': Computer.collection.get(label="localhost"), |
There was a problem hiding this comment.
| 'computer': Computer.collection.get(label="localhost"), | |
| 'computer': load_computer(label="localhost"), |
There was a problem hiding this comment.
Isn't load_computer much simples than Computer.collection.get?
There was a problem hiding this comment.
Both do the same job. Do you mean from user friendliness point of view?
Then yes maybe
There was a problem hiding this comment.
Can we make computer optional in the
StashCalculation? So by default the computer of the calcjob is used. Then in the docs we do not even mention it. Or we mention it in a separate section. I am not sure how the validation process kicks before one can change the metadata in the Calcjob.
https://github.com/aiidateam/aiida-core/pull/6861/files#r2081325332
I don't mean to make it in this PR optional, but if it is possible I would do it in another PR before merging this one
EDIT: discussed with @khsrali --> created issue for this #6871
EDIT#2: discussed with @agoscinski --> closed issue #6871
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6861 +/- ##
==========================================
+ Coverage 78.59% 78.61% +0.02%
==========================================
Files 564 564
Lines 43128 43128
==========================================
+ Hits 33891 33899 +8
+ Misses 9237 9229 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Please reply to this https://github.com/aiidateam/aiida-core/pull/6861/files#r2081308084 then we can merge
|
NOTE:
|
agoscinski
force-pushed
the
doc/stashing-caljob
branch
from
bf168ba to
20efa61
Compare
|
@khsrali can you squash merge. Not sure if you want specific commit message. EDIT: Sorry I want to finish up for release so I squashed. I hope message is fine |
agoscinski
force-pushed
the
doc/stashing-caljob
branch
from
20efa61 to
fb6746e
Compare
agoscinski
changed the title
StashCalculationStashCalculation explanation to RTD
Following #6839