Update botocore to 1.37.3

[stj]

Description of Change

Update the botocore to version 1.37.3.
Includes changes to support for the smithy-rpc-v2-cbor protocol.

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

• I have added change info to CHANGES.rst
• If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
  • Detailed description of issue
  • Alternative methods considered (if any)
  • How issue is being resolved
  • How issue can be reproduced
• If this is providing a new feature (can be provided via link to issue with these details):
  • Detailed description of new feature
  • Why needed
  • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

• I have read and followed CONTRIBUTING.rst
• I have updated test_patches.py where/if appropriate (also check if no changes necessary)
• I have ensured that the awscli/boto3 versions match the updated botocore version

[thehesiod]

cool thanks! we'll review shortly

[stj]

Thanks. I am planning to create a few more PRs to get to at least 1.37.20.
Though I will wait for feedback on this PR to learn more about the process before starting that work.

Might force push to address the commit signature requirement.

[thehesiod]

diff: boto/botocore@1.37.0...1.37.2

[albarsil]

praise: Nice initiative! This PR is required for projects that use botocore==1.37.25 and need aiobotocore.

[codecov]

Codecov Report

Attention: Patch coverage is 96.61017% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (54dba34) to head (e208ffd).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
tests/botocore_tests/unit/test_protocols.py	96.61%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
+ Coverage   90.63%   90.96%   +0.33%     
==========================================
  Files          67       68       +1     
  Lines        6597     6774     +177     
==========================================
+ Hits         5979     6162     +183     
+ Misses        618      612       -6     

Flag	Coverage Δ
unittests	90.96% <96.61%> (+0.33%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[nalbion]

botocore 1.37.25 please - this supports Anthropic prompt caching

[stj]

I merged and pushed a change. The parser method is now async for all AioParsers, making the interface more consistent. Insight the parser classes the _do_parse method can be async or sync. Let me know if that change requires more entries in tests/test_patches.py to cover these changes. My current assumption is that parsers are an internal class and not documented for public use. If they are public, this will be a breaking change.

[thehesiod]

thanks will take a look soon, under some high pressure at work (and home) this week

[stj]

The last commit are output protocol tests that I copied from botocore and adjusted to work with asyncio.
It got coverage of parsers.py to 81% compared to 73% on the main branch. Though, overall coverage went down 1% from 91% to 90%. I'll wait for feedback before making more changes.

[jakob-keller]

Thank you for preparing the PR. I agree that moving parse() up to AioResponseParser is a good idea. Would you mind putting that in a separate PR? That would simplify reviews.

[stj]

@jakob-keller created pull #1328

[jakob-keller]

@stj: Since #1347 has been merged, this could now move forward. Do you want to update the PR or should I prepare a fresh one? Mine is more or less ready to go.

[stj]

@jakob-keller I merged master, resolved conflicts and adjusted my changes.
Still a lot of copied tests from upstream botocore in this change.
Please take a look.

[jakob-keller]

I reviewed everything except the unit tests. Could you look at my comments. Fell free to copy over anything from https://github.com/aio-libs/aiobotocore/pull/1348/files

[jakob-keller]

Looks like there are some unverified commits in there. Can you rectify that? Otherwise, I would just try to squash everything.

[stj]

@jakob-keller thanks for the thorough reviews. Admit, I didn't do a good job keeping track on what happened on master after I created this PR. Thanks for working with me to get this done. Still much to learn for me on how aiobotocore works with botocore and the design of both libraries. This PR is now just pulling in the protocol tests from upstream and doesn't do anything that is in the PR description. Fell free to close it if the value of this isn't worth the added maintenance burden.

[jakob-keller]

@jakob-keller thanks for the thorough reviews. Admit, I didn't do a good job keeping track on what happened on master after I created this PR. Thanks for working with me to get this done. Still much to learn for me on how aiobotocore works with botocore and the design of both libraries. This PR is now just pulling in the protocol tests from upstream and doesn't do anything that is in the PR description. Fell free to close it if the value of this isn't worth the added maintenance burden.

On the contrary: Thanks a lot for your contributions and persistence! I still remember the steep learning curve when I contributed my first version bump. It all looks easier than it actually is.