Skip to content

Patch ResponseParser.parse() and others to prepare for upstream bump #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Apr 26, 2025

Description of Change

Patch ResponseParser.parse() as well as ClientArgsCreator.get_client_args(), Endpoint.__init__(), and EventStream._parse_event() in preparation for #1323.

Based on #1328 by @stj

Assumptions

  • Thanks to Patch ResponseParser and remaining subclasses #1329, we may be sure that all parsers have been patched.
  • parsers.AioResponseParser and many of its subclasses have not yet been released to PyPI. It is therefore considered safe to patch .parse() and remove checks in calling codepaths.

Checklist for All Submissions

  • I have added change info to CHANGES.rst: implied in first item for pending release 2.22.0
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

@jakob-keller jakob-keller force-pushed the patch-ResponseParser.parse branch 3 times, most recently from 75d883d to 40d274c Compare April 26, 2025 22:57
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.83%. Comparing base (967665c) to head (4e5e435).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
aiobotocore/endpoint.py 77.77% 2 Missing ⚠️
aiobotocore/parsers.py 95.45% 1 Missing ⚠️
aiobotocore/response.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
- Coverage   90.83%   90.83%   -0.01%     
==========================================
  Files          67       67              
  Lines        6559     6569      +10     
==========================================
+ Hits         5958     5967       +9     
- Misses        601      602       +1     
Flag Coverage Δ
unittests 90.83% <92.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller jakob-keller enabled auto-merge April 26, 2025 22:59
@jakob-keller jakob-keller requested a review from thehesiod April 26, 2025 23:00
@jakob-keller jakob-keller added the enhancement New feature or request label Apr 26, 2025
@jakob-keller jakob-keller force-pushed the patch-ResponseParser.parse branch from 40d274c to 5abed90 Compare April 29, 2025 06:46
@jakob-keller jakob-keller force-pushed the patch-ResponseParser.parse branch from 5abed90 to 25b5186 Compare April 29, 2025 06:51
@jakob-keller jakob-keller requested a review from thehesiod April 29, 2025 06:54
@jakob-keller jakob-keller changed the title Patch EventStream._parse_event() and ResponseParser.parse() Patch ResponseParser.parse() and others to prepare for upstream bump Apr 29, 2025
@jakob-keller jakob-keller force-pushed the patch-ResponseParser.parse branch from 25b5186 to 4e5e435 Compare April 29, 2025 06:56
@jakob-keller jakob-keller added this pull request to the merge queue Apr 29, 2025
@jakob-keller
Copy link
Collaborator Author

@thehesiod: Thanks for the thorough review, as always!

Merged via the queue into aio-libs:master with commit 823cd3b Apr 29, 2025
34 of 36 checks passed
@jakob-keller jakob-keller deleted the patch-ResponseParser.parse branch April 29, 2025 16:38
@thehesiod
Copy link
Collaborator

@thehesiod: Thanks for the thorough review, as always!

my pleasure, thanks for all the hard work!

@jakob-keller jakob-keller mentioned this pull request Apr 29, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants