-
-
Notifications
You must be signed in to change notification settings - Fork 198
Patch ResponseParser.parse()
and others to prepare for upstream bump
#1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch ResponseParser.parse()
and others to prepare for upstream bump
#1347
Conversation
75d883d
to
40d274c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1347 +/- ##
==========================================
- Coverage 90.83% 90.83% -0.01%
==========================================
Files 67 67
Lines 6559 6569 +10
==========================================
+ Hits 5958 5967 +9
- Misses 601 602 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
40d274c
to
5abed90
Compare
5abed90
to
25b5186
Compare
EventStream._parse_event()
and ResponseParser.parse()
ResponseParser.parse()
and others to prepare for upstream bump
25b5186
to
4e5e435
Compare
@thehesiod: Thanks for the thorough review, as always! |
my pleasure, thanks for all the hard work! |
Description of Change
Patch
ResponseParser.parse()
as well asClientArgsCreator.get_client_args()
,Endpoint.__init__()
, andEventStream._parse_event()
in preparation for #1323.Based on #1328 by @stj
Assumptions
ResponseParser
and remaining subclasses #1329, we may be sure that all parsers have been patched.parsers.AioResponseParser
and many of its subclasses have not yet been released to PyPI. It is therefore considered safe to patch.parse()
and remove checks in calling codepaths.Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions