Skip to content

Commit f7afb77

Browse files
committed
adjust tests with the new context manager
1 parent c87bb8b commit f7afb77

File tree

5 files changed

+23
-15
lines changed

5 files changed

+23
-15
lines changed

tests/acceptance/conftest.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,18 @@
66

77

88
@pytest.fixture
9-
async def valkey_cache(valkey_client):
9+
async def valkey_cache(valkey_config):
1010
from aiocache.backends.valkey import ValkeyCache
1111

12-
async with ValkeyCache(namespace="test", client=valkey_client) as cache:
12+
async with ValkeyCache(namespace="test", config=valkey_config) as cache:
1313
yield cache
1414
await asyncio.gather(*(cache.delete(k) for k in (*Keys, KEY_LOCK)))
1515

1616

1717
@pytest.fixture
1818
async def memory_cache():
1919
from aiocache.backends.memory import SimpleMemoryCache
20+
2021
async with SimpleMemoryCache(namespace="test") as cache:
2122
yield cache
2223
await asyncio.gather(*(cache.delete(k) for k in (*Keys, KEY_LOCK)))
@@ -25,6 +26,7 @@ async def memory_cache():
2526
@pytest.fixture
2627
async def memcached_cache():
2728
from aiocache.backends.memcached import MemcachedCache
29+
2830
async with MemcachedCache(namespace="test") as cache:
2931
yield cache
3032
await asyncio.gather(*(cache.delete(k) for k in (*Keys, KEY_LOCK)))

tests/conftest.py

+11-3
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,20 @@ def decode_responses():
1212

1313

1414
@pytest.fixture
15-
async def valkey_client(max_conns, decode_responses):
16-
from glide import GlideClient, GlideClientConfiguration, NodeAddress
15+
def valkey_config():
16+
from glide import GlideClientConfiguration, NodeAddress
1717

1818
addresses = [NodeAddress("localhost", 6379)]
1919
conf = GlideClientConfiguration(addresses=addresses, database_id=0)
20-
client = await GlideClient.create(conf)
20+
21+
yield conf
22+
23+
24+
@pytest.fixture
25+
async def valkey_client(max_conns, decode_responses, valkey_config):
26+
from glide import GlideClient
27+
28+
client = await GlideClient.create(valkey_config)
2129

2230
yield client
2331

tests/performance/conftest.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,18 @@
22

33

44
@pytest.fixture
5-
async def valkey_cache(valkey_client):
5+
async def valkey_cache(valkey_config):
66
# valkey connection pool raises ConnectionError but doesn't wait for conn reuse
77
# when exceeding max pool size.
88
from aiocache.backends.valkey import ValkeyCache
9-
async with ValkeyCache(namespace="test", client=valkey_client) as cache:
9+
10+
async with ValkeyCache(namespace="test", config=valkey_config) as cache:
1011
yield cache
1112

1213

1314
@pytest.fixture
1415
async def memcached_cache():
1516
from aiocache.backends.memcached import MemcachedCache
17+
1618
async with MemcachedCache(namespace="test", pool_size=1) as cache:
1719
yield cache

tests/ut/backends/test_valkey.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@ async def test_set(self, valkey):
5555

5656
async def test_set_cas_token(self, mocker, valkey):
5757
mocker.patch.object(valkey, "_cas")
58-
await valkey._set(
59-
Keys.KEY, "value", _cas_token="old_value", _conn=valkey.client
60-
)
58+
await valkey._set(Keys.KEY, "value", _cas_token="old_value", _conn=valkey.client)
6159
valkey._cas.assert_called_with(
6260
Keys.KEY, "value", "old_value", ttl=None, _conn=valkey.client
6361
)
@@ -219,9 +217,7 @@ def test_parse_uri_path(self, path, expected, valkey_client):
219217
["my_ns", "my_ns:" + ensure_key(Keys.KEY)],
220218
), # noqa: B950
221219
)
222-
def test_build_key_double_dot(
223-
self, set_test_namespace, valkey_cache, namespace, expected
224-
):
220+
def test_build_key_double_dot(self, set_test_namespace, valkey_cache, namespace, expected):
225221
assert valkey_cache.build_key(Keys.KEY, namespace) == expected
226222

227223
def test_build_key_no_namespace(self, valkey_cache):

tests/ut/conftest.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ def base_cache():
5555

5656

5757
@pytest.fixture
58-
async def valkey_cache(valkey_client):
58+
async def valkey_cache(valkey_config):
5959
from aiocache.backends.valkey import ValkeyCache
6060

61-
async with ValkeyCache(client=valkey_client) as cache:
61+
async with ValkeyCache(config=valkey_config) as cache:
6262
yield cache
6363

6464

0 commit comments

Comments
 (0)