Preserve type hints in decorator (#512) #984
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @cached decorator did not preserve type hints, breaking static analysis.
|
The tasks under the milestone need to be implemented in roughly the order listed: Type annotations will not work correctly before then (we already enabled them in 0.12 and had to disable them again). |
|
Wait, Github has removed the ordering of milestone issues... that's rather annoying... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @cached decorator did not preserve type hints, breaking static analysis.
What do these changes do?
This PR fixes type hint preservation in the
@cacheddecorator by usingParamSpecandTypeVarin its implementation.It also adds a test to verify that type hints are correctly preserved on decorated functions.
Are there changes in behavior for the user?
No user-facing behavior changes, but static analysis and type checking for decorated functions now work as expected in pyright.
On the other hand, mypy does not correctly infer the return type of the decorated function. This appears to be a limitation with mypy.
Related issue number
Fixes #512
Checklist