feat(typing)!: make cache generic over value (#608) #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make BaseCache generic over both key and value types for improved type safety. - Update all cache backends and usages to use BaseCache[KeyType, ValueType]. - Improve type annotations for cache methods. - Update RedLock, OptimisticLock, and test utilities for new generics. BREAKING CHANGE: BaseCache and all backends now require two type parameters (key, value). Existing code using a single type parameter must be updated. Refs: aio-libs#608
|
|
||
| import aiomcache | ||
|
|
||
| from aiocache.base import BaseCache | ||
| from aiocache.serializers import JsonSerializer | ||
|
|
||
|
|
||
| class MemcachedBackend(BaseCache[bytes]): | ||
| class MemcachedBackend(BaseCache[bytes, Any]): |
There was a problem hiding this comment.
I think all these need to be defined as a TypeVar. Then the user would need to annotate their code as: MemcachedCache[Any] and similar.
Though, probably better to get #684 done before this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are there changes in behavior for the user?
BREAKING CHANGE: BaseCache and all backends now require two type parameters (key, value). Existing code using a single type parameter must be updated.
Before, users could write:
Users must now write:
Related issue number
Fixes: #608
Checklist