Source-Stripe: Updating CBT to use invoices and customer parents #58633
+116
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericvanbenschoten-dv01 is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
ericvanbenschoten-dv01
had a problem deploying
to
community-ci
GitHub Actions
Error
ericvanbenschoten-dv01
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
ericvanbenschoten-dv01
had a problem deploying
to
community-ci
GitHub Actions
Error
| @@ -308,6 +308,8 @@ definitions: | |||
| $parameters: | |||
| request_parameters: | |||
| types[]: '{{["customer.created", "customer.updated", "customer.deleted"]}}' | |||
| cursor_field: updated | |||
| lookback_window_days: 1 | |||
There was a problem hiding this comment.
How does this work with incremental streams?
There was a problem hiding this comment.
Removed and using CustomStateMigrations class to roll back the cursors
|
|
||
| class CustomerIdPartitionRouter(SubstreamPartitionRouter): | ||
| def stream_slices(self) -> Iterable[StreamSlice]: # type: ignore | ||
| parent_slices = list(super().stream_slices()) |
There was a problem hiding this comment.
I thought you had to iterate through each of the substream partition configs
ericvanbenschoten-dv01
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
ericvanbenschoten-dv01
had a problem deploying
to
community-ci
GitHub Actions
Error
ericvanbenschoten-dv01
had a problem deploying
to
community-ci
GitHub Actions
Error
ericvanbenschoten-dv01
force-pushed
the
ev-stripe-cbt-fixes
branch
from
6c1afa3 to
9f7607e
Compare
ericvanbenschoten-dv01
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
ericvanbenschoten-dv01
had a problem deploying
to
community-ci
GitHub Actions
Error
ericvanbenschoten-dv01
had a problem deploying
to
community-ci
GitHub Actions
Error
Comment on lines
+886
to
+888
| state_migrations: | ||
| - type: CustomStateMigration | ||
| class_name: source_stripe.components.CustomerBalanceStateMigration |
There was a problem hiding this comment.
get_updated_state has been deprecating using the CustomStateMigration to rollback cursors: https://docs.airbyte.com/platform/connector-development/config-based/understanding-the-yaml-file/reference#/definitions/CustomStateMigration
ericvanbenschoten-dv01
changed the title
ericvanbenschoten-dv01
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
ericvanbenschoten-dv01
had a problem deploying
to
community-ci
GitHub Actions
Error
ericvanbenschoten-dv01
had a problem deploying
to
community-ci
GitHub Actions
Error
ericvanbenschoten-dv01
force-pushed
the
ev-stripe-cbt-fixes
branch
from
e5b6d30 to
d5018ae
Compare
ericvanbenschoten-dv01
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
ericvanbenschoten-dv01
requested a deployment
to
community-ci
GitHub Actions
Waiting
ericvanbenschoten-dv01
requested a deployment
to
community-ci
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?