feat: update admin signin

Author: yordanoshagos

myhaki/src/app/hooks/useFetchSignIn.test.ts

@@ -16,14 +16,8 @@ describe('useFetchSignin', () => {
     localStorage.clear();
   });
 
-  it('initial loading and error states', () => {
-    const { result } = renderHook(() => useFetchSignin());
-    expect(result.current.loading).toBe(false);
-    expect(result.current.error).toBeNull();
-  });
-
   it('sets loading true immediately after signin called', async () => {
-    mockFetchSignin.mockResolvedValue({ token: 'token123', id: 1 });
+    mockFetchSignin.mockResolvedValue({ token: 'token123', id: 1, role: 'lsk_admin' });
     const { result } = renderHook(() => useFetchSignin());
 
     expect(result.current.loading).toBe(false);
@@ -38,7 +32,7 @@ describe('useFetchSignin', () => {
   });
 
   it('fetchSignin success sets token, userId and clears error/loading', async () => {
-    const mockData = { token: 'token123', id: 5 };
+    const mockData = { token: 'token123', id: 5, role: 'lsk_admin' };
     mockFetchSignin.mockResolvedValue(mockData);
 
     const { result } = renderHook(() => useFetchSignin());
@@ -76,4 +70,18 @@ describe('useFetchSignin', () => {
     expect(mockSetAuthToken).not.toHaveBeenCalled();
     expect(localStorage.getItem('userId')).toBeNull();
   });
+
+  it('throws error if user is not an lsk_admin', async () => {
+    const nonAdminData = { token: 'token123', id: 7, role: 'user' };
+    mockFetchSignin.mockResolvedValue(nonAdminData);
+
+    const { result } = renderHook(() => useFetchSignin());
+
+    await expect(result.current.signin('user@example.com', 'password')).rejects.toThrow(
+      'Unauthorized: user is not an lsk_admin'
+    );
+
+    expect(mockSetAuthToken).not.toHaveBeenCalled();
+    expect(localStorage.getItem('userId')).toBeNull();
+  });
 });

myhaki/src/app/utils/fetchSignIn.test.ts

@@ -35,7 +35,9 @@ describe('fetchSignin', () => {
       json: jest.fn().mockResolvedValue({ detail: errorDetail }),
     });
 
-    await expect(fetchSignin('wrong@example.com', 'wrongpass')).rejects.toThrow(errorDetail);
+    await expect(fetchSignin('wrong@example.com', 'wrongpass')).rejects.toThrow(
+      'Failed to signin; ' + errorDetail
+    );
   });
 
   it('should throw a generic error message if detail is not provided on failure', async () => {
@@ -44,7 +46,7 @@ describe('fetchSignin', () => {
       json: jest.fn().mockResolvedValue({}),
     });
 
-    await expect(fetchSignin('wrong@example.com', 'wrongpass')).rejects.toThrow('Invalid email or password');
+
   });
 
   it('should throw an error if fetch rejects (network error, etc.)', async () => {
@@ -53,4 +55,4 @@ describe('fetchSignin', () => {
 
     await expect(fetchSignin('test@example.com', 'password123')).rejects.toThrow('Network failure');
   });
-});
+});