Skip to content

Create profile page #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 24, 2025
Merged

Create profile page #11

merged 19 commits into from
Sep 24, 2025

Conversation

fionawesonga
Copy link
Collaborator

Engineers Checklist

What this PR does?

  • Implements a fully functional user profile page with form management, including image upload and preview.
  • Adds robust email validation to prevent form submission if the email format is invalid.
  • Enhances input user experience by applying cursor pointer style on inputs that changes to text cursor while typing.
  • Strengthens form validation and user feedback to improve overall UX and data accuracy.

Type of change

Please delete options that are not relevant.

  • Bug fix
  • Improvement
  • New feature
  • Breaking change
  • This change requires a documentation update
  • Optimization

How can it be tested?

  1. Navigate to the profile page after login.
  2. Try submitting the form with empty required fields and observe inline error messages without alerts.
  3. Enter invalid email formats and confirm that saving is blocked with an appropriate error message.
  4. Fill valid data and save successfully, viewing the success message.
  5. Test cursor changes on inputs during interaction.
  6. Verify image upload and preview function correctly.
  7. Use Cancel to revert unsaved changes.
Group 633207 (3)

lwambisrat
lwambisrat previously approved these changes Sep 24, 2025
View reviewed changes
akezasaloi
akezasaloi previously approved these changes Sep 24, 2025
View reviewed changes
@fionawesonga fionawesonga dismissed stale reviews from akezasaloi and lwambisrat via 4bad1e1 September 24, 2025 10:17
hunterachieng
hunterachieng reviewed Sep 24, 2025
View reviewed changes
@lwambisrat lwambisrat self-requested a review September 24, 2025 12:43
lwambisrat
lwambisrat previously approved these changes Sep 24, 2025
View reviewed changes
mahderbekele
mahderbekele previously approved these changes Sep 24, 2025
View reviewed changes
@akezasaloi akezasaloi self-requested a review September 24, 2025 12:46
yordanoshagos
yordanoshagos previously approved these changes Sep 24, 2025
View reviewed changes
akezasaloi
akezasaloi previously approved these changes Sep 24, 2025
View reviewed changes
akezasaloi
akezasaloi previously approved these changes Sep 24, 2025
View reviewed changes
hunterachieng
hunterachieng reviewed Sep 24, 2025
View reviewed changes
mahderbekele
mahderbekele previously approved these changes Sep 24, 2025
View reviewed changes
hunterachieng
hunterachieng reviewed Sep 24, 2025
View reviewed changes
myhaki/src/app/profile/page.tsx Outdated
useEffect(() => {
const userId = localStorage.getItem('userId');
if (!userId) {
setError('User not logged in');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the place I want fixed

@hunterachieng hunterachieng merged commit 1ee28a2 into develop Sep 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterachieng hunterachieng hunterachieng approved these changes

@akezasaloi akezasaloi akezasaloi approved these changes

@yordanoshagos yordanoshagos yordanoshagos approved these changes

@mahderbekele mahderbekele mahderbekele approved these changes

@lwambisrat lwambisrat Awaiting requested review from lwambisrat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fionawesonga @hunterachieng @akezasaloi @yordanoshagos @mahderbekele @lwambisrat