Skip to content

chore: use full telemetry context for MCP endpoints #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: use full telemetry context for MCP endpoints #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions akka-javasdk/src/main/scala/akka/javasdk/impl/SdkRunner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,8 +950,8 @@ private final class Sdk(

private def mcpEndpointFactory[E](mcpEndpointClass: Class[E]): McpEndpointConstructionContext => E = {
(context: McpEndpointConstructionContext) =>
// FIXME(tracing): add full telemetry context to McpRequestContext
val telemetryContext = context.openTelemetrySpan.map(OtelContext.root.`with`)

val telemetryContext = Option(context.telemetryContext)

lazy val mcpRequestContext = new McpRequestContext {
override def getPrincipals: Principals =
Expand Down
2 changes: 1 addition & 1 deletion project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ object Dependencies {
val ProtocolVersionMajor = 1
val ProtocolVersionMinor = 1
}
val AkkaRuntimeVersion = sys.props.getOrElse("akka-runtime.version", "1.5.13")
val AkkaRuntimeVersion = sys.props.getOrElse("akka-runtime.version", "1.5.14-1-6254924e-SNAPSHOT")
// NOTE: embedded SDK should have the AkkaVersion aligned, when updating RuntimeVersion, make sure to check
// if AkkaVersion and AkkaHttpVersion are aligned
// for prod code, they are marked as Provided, but testkit still requires the alignment
Expand Down
Loading