feat: telemetry reader for IT #965
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aludwiko
commented
Sep 10, 2025
| assertThat(balance2).isEqualTo(110); | ||
| }); | ||
|
|
||
| var steps = telemetryReader.getWorkflowSteps(TransferWorkflow.class, transferId); |
There was a problem hiding this comment.
Different approach, instead of using debugId, I can filter based on the component and id. We still have to send the request with a debug header, but we can hide that fact in our internals.
There was a problem hiding this comment.
Good. Can also use the always debug sampler.
aludwiko
commented
Sep 16, 2025
| () -> { | ||
| List<String> workflowSteps = | ||
| telemetryReader.getWorkflowSteps(TransferWorkflow.class, transferId); | ||
| assertThat(workflowSteps).containsOnly("withdraw-step", "deposit-step", "logAndStop"); |
There was a problem hiding this comment.
@pvlugter unfortunately all tracing assertions should be wrapped with Awaitility. Sometimes spans arrive later than the observable outcome, and the assertion fails.
There was a problem hiding this comment.
Yeah, it's often going to need to wait. We could also build in some await expects with timeouts. Like the way that akka testkits work, with expecting messages or stream elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires: https://github.com/lightbend/akka-runtime/pull/4250/files