Have includes occur in the correct order #404
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Includes are currently handled incorrectly. Whether they occur first or last in the file they are given precedence, as if they occurred last. So if you do
where
other.confisthe result is
with the value of
acoming from the included file whereas, because the include occurs first in the file, the correct result should bea: 1.This change fixes the problem though admittedly I don't understand the code well enough to know if it's the most appropriate solution. I also haven't added a test case since I could find no existing
includetests. If you're interested in merging this I'm happy to add a test.