Skip to content

[WIP]: resolve ThrottlerTransportAdapter NRE #7565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from
+312 −664
Draft

[WIP]: resolve ThrottlerTransportAdapter NRE #7565

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e2249dc
`ThrottleTransportAdapter`: clean up `TBD`s
Aaronontheweb Mar 23, 2025
41328cc
`ISystemMessage`: clean up `TBD`s
Aaronontheweb Mar 23, 2025
0ca55d4
change `ActorRef.Extensions` to support nullability
Aaronontheweb Mar 23, 2025
42aaaff
Merge branch 'dev' into fix-7564-ThrottlerNRE
Aaronontheweb Mar 23, 2025
b392b9b
`ActorRef` mutability and API fixes
Aaronontheweb Mar 23, 2025
fb0a49b
clean up
Aaronontheweb Mar 23, 2025
e91cfc3
style fixes to `SystemMessageSerializer`
Aaronontheweb Mar 23, 2025
4f081f3
cleaned up `ISystemMessage` comments
Aaronontheweb Mar 23, 2025
56f8ad7
more `ISystemMessage` comment cleanup
Aaronontheweb Mar 23, 2025
b6ad3f5
working on nullability fixes for `ISystemMessage`
Aaronontheweb Mar 23, 2025
c7a6336
Merge branch 'dev' into fix-7564-ThrottlerNRE
Aaronontheweb Mar 23, 2025
1153c5d
Merge branch 'dev' into fix-7564-ThrottlerNRE
Aaronontheweb May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ namespace Akka.Actor
}
public class static ActorRefExtensions
{
public static Akka.Actor.IActorRef GetOrElse(this Akka.Actor.IActorRef actorRef, System.Func<Akka.Actor.IActorRef> elseValue) { }
public static Akka.Actor.IActorRef GetOrElse([System.Runtime.CompilerServices.NullableAttribute(2)] this Akka.Actor.IActorRef actorRef, System.Func<Akka.Actor.IActorRef> elseValue) { }
public static bool IsNobody(this Akka.Actor.IActorRef actorRef) { }
}
public class static ActorRefFactoryExtensions
Expand Down Expand Up @@ -1409,15 +1409,10 @@ namespace Akka.Actor
}
public sealed class Nobody : Akka.Actor.MinimalActorRef
{
public static Akka.Actor.Nobody Instance;
public static readonly Akka.Actor.Nobody Instance;
Copy link
Member Author

@Aaronontheweb Aaronontheweb Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never should have been mutable

public override Akka.Actor.ActorPath Path { get; }
public override Akka.Actor.IActorRefProvider Provider { get; }
public override Akka.Util.ISurrogate ToSurrogate(Akka.Actor.ActorSystem system) { }
public class NobodySurrogate : Akka.Util.ISurrogate
Copy link
Member Author

@Aaronontheweb Aaronontheweb Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never needed to be part of the public API - just the ISurrogate interface is enough.

{
public NobodySurrogate() { }
public Akka.Util.ISurrogated FromSurrogate(Akka.Actor.ActorSystem system) { }
}
}
public class OneForOneStrategy : Akka.Actor.SupervisorStrategy, System.IEquatable<Akka.Actor.OneForOneStrategy>
{
Expand Down
9 changes: 2 additions & 7 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ namespace Akka.Actor
}
public class static ActorRefExtensions
{
public static Akka.Actor.IActorRef GetOrElse(this Akka.Actor.IActorRef actorRef, System.Func<Akka.Actor.IActorRef> elseValue) { }
public static Akka.Actor.IActorRef GetOrElse([System.Runtime.CompilerServices.NullableAttribute(2)] this Akka.Actor.IActorRef actorRef, System.Func<Akka.Actor.IActorRef> elseValue) { }
public static bool IsNobody(this Akka.Actor.IActorRef actorRef) { }
}
public class static ActorRefFactoryExtensions
Expand Down Expand Up @@ -1407,15 +1407,10 @@ namespace Akka.Actor
}
public sealed class Nobody : Akka.Actor.MinimalActorRef
{
public static Akka.Actor.Nobody Instance;
public static readonly Akka.Actor.Nobody Instance;
public override Akka.Actor.ActorPath Path { get; }
public override Akka.Actor.IActorRefProvider Provider { get; }
public override Akka.Util.ISurrogate ToSurrogate(Akka.Actor.ActorSystem system) { }
public class NobodySurrogate : Akka.Util.ISurrogate
{
public NobodySurrogate() { }
public Akka.Util.ISurrogated FromSurrogate(Akka.Actor.ActorSystem system) { }
}
}
public class OneForOneStrategy : Akka.Actor.SupervisorStrategy, System.IEquatable<Akka.Actor.OneForOneStrategy>
{
Expand Down
Loading