Skip to content

Update LiteralUnion type definition so it doesnt cast everything to string #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Update LiteralUnion type definition so it doesnt cast everything to string #1832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/devsupport/typings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export type ChildrenWithProps<Props> = ChildrenProp<ReactElement<Props>>;
* https://github.com/microsoft/TypeScript/issues/29729#issuecomment-505826972
*/
// eslint-disable-next-line @typescript-eslint/ban-types
export type LiteralUnion<T extends U, U = string> = T | (U & {});
export type LiteralUnion<T extends U, U = string> = T | (string & {});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @mi5ha,

This won't work in the case you wanna change U to number for example (there you should get a type error).
image

So I think changing this type to the following would be more correct, as you then get ts errors in the numbers case, while also receiving auto-completion hints.

type LiteralUnion<T extends U, U = string> = T | (U & Record<never, never>);

image
image


export type EvaStatus = LiteralUnion<'basic' | 'primary' | 'success' | 'info' | 'warning' | 'danger' | 'control'>;
export type EvaSize = LiteralUnion<'tiny' | 'small' | 'medium' | 'large' | 'giant'>;
Expand Down