Open
Conversation
added 3 commits
January 18, 2018 11:34
Updated logic for talr-vpcdns to conform to new SNS message format used to detect core CloudFormation stack completion status and initiate a peering connection.
Repository owner
deleted a comment
Jan 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Message' payload included with the SNS message sent to detect core stack completion has changed. This caused the function to fail to populate linked account information to detect both core stack completion and the linked account VPC.
Patched the if-statement logic to check data differently before proceeding that conforms to the new payload.