Skip to content

Conversation

rthomare
Copy link
Contributor

@rthomare rthomare commented Feb 28, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on implementing Multi-Factor Authentication (MFA) throughout the application, adding support for new MFA functionalities, and enhancing related components, documentation, and error handling.

Detailed summary

  • Added useMFA hook for managing MFA operations.
  • Introduced new MFA-related components and modals.
  • Updated various files to support MFA, including new methods in BaseSignerClient.
  • Enhanced error handling for MFA requirements.
  • Updated documentation to reflect MFA changes.
  • Added new tests for MFA functionalities.

The following files were skipped due to too many changes: site/pages/react/mfa/social-login.mdx, account-kit/react/src/components/auth/card/loading/totp.tsx, account-kit/react/src/components/auth/sections/EmailAuth.tsx, site/pages/react/mfa/email-otp.mdx, account-kit/signer/test/mocks/MockAlchemySignerWebClient.ts, examples/ui-demo/src/components/ui/OTPInput.tsx, site/sidebar/reference/account-kit/signer.ts, site/pages/react/mfa/email-magic-link.mdx, site/pages/signer/authentication/mfa.mdx, examples/ui-demo/src/components/modals/MFA/MFAModal.tsx, examples/ui-demo/src/components/icons/google-play.tsx, account-kit/signer/src/client/index.ts, site/pages/react/mfa/setup-mfa.mdx, account-kit/signer/test/base.test.ts, examples/ui-demo/src/components/icons/app-store.tsx, examples/ui-demo/src/components/icons/alchemy-two-tone.tsx, account-kit/signer/src/base.ts, examples/ui-demo/src/components/ui/Spinner.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 6:20pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 6:20pm

Copy link
Contributor

graphite-app bot commented Feb 28, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@rthomare rthomare changed the title Mfa/demo DO NOT MREGE: Mfa/demo Feb 28, 2025
@blakecduncan blakecduncan changed the title DO NOT MREGE: Mfa/demo feat: add mfa on sign in with an authenticator app Apr 4, 2025
Copy link
Collaborator

@blakecduncan blakecduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakecduncan blakecduncan merged commit b9315c5 into main Apr 4, 2025
7 checks passed
@blakecduncan blakecduncan deleted the mfa/demo branch April 4, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants