-
Notifications
You must be signed in to change notification settings - Fork 197
fix: ensure session persistence on IOS #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
16861fd
feat: update logo (#1454)
RobChangCA 018b2c3
fix: update keychain implementation to declear variables earlier duri…
iykazrji c3b9b4e
Merge branch 'main' into iyk/investigate-ios-sessions
iykazrji 5ca1877
Merge branch 'main' into iyk/investigate-ios-sessions
iykazrji 3c9d35e
feat: use struct for keychain utilities as opposed to class
iykazrji bd826ed
Merge branch 'main' into iyk/investigate-ios-sessions
iykazrji 9db96d3
Merge branch 'main' into iyk/investigate-ios-sessions
iykazrji 4de5655
Merge branch 'main' into iyk/investigate-ios-sessions
iykazrji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
58 changes: 58 additions & 0 deletions
58
account-kit/rn-signer/ios/implementation/KeychainHelper.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
import Foundation | ||
import Security | ||
import CryptoKit | ||
|
||
let ACCOUNT_KIT_EPHEMERAL_PRIVATE_KEY = "accountKitEphemeralPrivateKey" | ||
|
||
let save_ephemeral_private_key_query: [String: Any] = [ | ||
kSecClass as String: kSecClassGenericPassword, | ||
kSecAttrAccount as String: ACCOUNT_KIT_EPHEMERAL_PRIVATE_KEY, | ||
kSecAttrAccessible as String: kSecAttrAccessibleAfterFirstUnlock | ||
] | ||
|
||
let get_ephemeral_private_key_query: [String: Any] = [ | ||
kSecClass as String: kSecClassGenericPassword, | ||
kSecAttrAccount as String: ACCOUNT_KIT_EPHEMERAL_PRIVATE_KEY, | ||
kSecReturnData as String: true, | ||
kSecMatchLimit as String: kSecMatchLimitOne | ||
] | ||
|
||
let delete_ephemeral_private_key_query: [String: Any] = [ | ||
kSecClass as String: kSecClassGenericPassword, | ||
kSecAttrAccount as String: ACCOUNT_KIT_EPHEMERAL_PRIVATE_KEY | ||
] | ||
|
||
|
||
iykazrji marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
struct PrivateKeyChainUtilities { | ||
@available(*, unavailable) private init() {} | ||
|
||
static func savePrivateKeyToKeychain(_ privateKey: P256.KeyAgreement.PrivateKey) { | ||
let keyData = privateKey.rawRepresentation | ||
|
||
var _saveEphemeralPrivateKeyQuery = save_ephemeral_private_key_query | ||
_saveEphemeralPrivateKeyQuery.updateValue(keyData, forKey: kSecValueData as String) | ||
|
||
SecItemDelete(_saveEphemeralPrivateKeyQuery as CFDictionary) | ||
SecItemAdd(_saveEphemeralPrivateKeyQuery as CFDictionary, nil) | ||
} | ||
|
||
static func getPrivateKeyFromKeychain() -> P256.KeyAgreement.PrivateKey? { | ||
var result: AnyObject? | ||
let status = SecItemCopyMatching(get_ephemeral_private_key_query as CFDictionary, &result) | ||
|
||
if status == errSecSuccess, let keyData = result as? Data { | ||
do { | ||
return try P256.KeyAgreement.PrivateKey(rawRepresentation: keyData) | ||
} catch { | ||
print("❌ Failed to decode private key: \(error)") | ||
return nil | ||
} | ||
} | ||
|
||
return nil | ||
} | ||
|
||
static func deletePrivateKeyFromKeychain() { | ||
SecItemDelete(delete_ephemeral_private_key_query as CFDictionary) | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.