Skip to content

Conversation

andysim3d
Copy link
Collaborator

@andysim3d andysim3d commented Mar 19, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on restructuring the signer-sdk by removing outdated files, introducing new classes for user and request handling, and improving the overall API design. It also updates the build configuration to support Gradle.

Detailed summary

  • Deleted obsolete files: pom.xml, GetUser.java, AuthUser.java, SignRawMessage.java.
  • Added SignerSeriveException class for exception handling.
  • Introduced UserStamper record for user and stamper pairing.
  • Created StampedRequest and HttpConfig records with detailed constructors.
  • Added AuthJWT and SignMessage classes with request/response records.
  • Updated SignerClient to use UserStamper and refactored authentication methods.
  • Modified .gitignore to exclude build directories.
  • Updated build configuration to Gradle with Java compatibility settings.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 6:05pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 6:05pm

Copy link
Collaborator

@adamegyed adamegyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andysim3d andysim3d merged commit a6f5477 into main Mar 20, 2025
7 checks passed
@andysim3d andysim3d deleted the andy/refactor-java-sdk branch March 20, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants