-
Notifications
You must be signed in to change notification settings - Fork 197
docs: correctly use authenticate in docs #1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
69ccb14
to
8efc329
Compare
For discussion: do we want to be encouraging the use of |
@dphilipson Yeah that's a good question. I was thinking the async function might be easier to understand for someone not familiar with react query. I think you are right though we should probably recommend the non async one. |
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on refactoring authentication handling in various components by changing the
authenticate
function calls from asynchronous (async/await
) to synchronous style, while also adding success and error handling callbacks.Detailed summary
MyAuthComponent
to includeauthenticateAsync
.handleGoogleRedirectLogin
,handleGooglePopupLogin
, and other login methods to use synchronousauthenticate
calls.onSuccess
andonError
callbacks for better error handling and success feedback.