Skip to content

Conversation

blakecduncan
Copy link
Collaborator

@blakecduncan blakecduncan commented Mar 19, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on refactoring authentication handling in various components by changing the authenticate function calls from asynchronous (async/await) to synchronous style, while also adding success and error handling callbacks.

Detailed summary

  • Updated MyAuthComponent to include authenticateAsync.
  • Changed handleGoogleRedirectLogin, handleGooglePopupLogin, and other login methods to use synchronous authenticate calls.
  • Added onSuccess and onError callbacks for better error handling and success feedback.
  • Refactored email and passkey related methods to follow the same pattern.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 1:44pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 1:44pm

Copy link
Contributor

graphite-app bot commented Mar 19, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@dphilipson
Copy link
Contributor

For discussion: do we want to be encouraging the use of authenticateAsync over authenticate? I'd say using authenticate would typically lead to more robust apps, although it does possibly have a bit of knowledge overhead.

@blakecduncan
Copy link
Collaborator Author

For discussion: do we want to be encouraging the use of authenticateAsync over authenticate? I'd say using authenticate would typically lead to more robust apps, although it does possibly have a bit of knowledge overhead.

@dphilipson Yeah that's a good question. I was thinking the async function might be easier to understand for someone not familiar with react query. I think you are right though we should probably recommend the non async one.

@blakecduncan blakecduncan changed the title docs: use authenticateAsync docs: correctly use authenticate in docs Mar 24, 2025
@blakecduncan blakecduncan requested a review from howydev as a code owner March 25, 2025 13:28
@blakecduncan blakecduncan merged commit 0a1a03d into main Mar 25, 2025
11 checks passed
@blakecduncan blakecduncan deleted the blake/update-login-docs branch March 25, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants