build: add gradle generated files in java signer SDK #1473
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure on whether or not all of these should be included.
Per gradle reference, they recommend checking in the
gradlew
files to VCS: https://docs.gradle.org/current/userguide/gradle_wrapper.htmlAnd the current .gitignore specifically includes
gradle/wrapper/gradle-wrapper.jar
to be committed, but the file is not itself present.For context, these files are generated after running a "gradle sync" in IntelliJ IDEA.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR updates the Gradle wrapper configuration and scripts for the
account-kit/java/signer-sdk
project, specifically enhancing compatibility with Gradle 8.10 and ensuring proper Java environment setup.Detailed summary
distributionBase
,distributionPath
,distributionUrl
,networkTimeout
,validateDistributionUrl
,zipStoreBase
, andzipStorePath
togradle-wrapper.properties
.gradlew.bat
andgradlew
.gradlew.bat
.gradlew
.