Skip to content

Conversation

adamegyed
Copy link
Collaborator

@adamegyed adamegyed commented Mar 20, 2025

Not 100% sure on whether or not all of these should be included.

Per gradle reference, they recommend checking in the gradlew files to VCS: https://docs.gradle.org/current/userguide/gradle_wrapper.html

And the current .gitignore specifically includes gradle/wrapper/gradle-wrapper.jar to be committed, but the file is not itself present.

For context, these files are generated after running a "gradle sync" in IntelliJ IDEA.

Pull Request Checklist


PR-Codex overview

This PR updates the Gradle wrapper configuration and scripts for the account-kit/java/signer-sdk project, specifically enhancing compatibility with Gradle 8.10 and ensuring proper Java environment setup.

Detailed summary

  • Added distributionBase, distributionPath, distributionUrl, networkTimeout, validateDistributionUrl, zipStoreBase, and zipStorePath to gradle-wrapper.properties.
  • Included copyright and licensing information in gradlew.bat and gradlew.
  • Improved Java environment detection and error handling in gradlew.bat.
  • Implemented POSIX-compliant shell script features in gradlew.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 9:04pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 9:04pm

Copy link
Contributor

graphite-app bot commented Mar 20, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@adamegyed
Copy link
Collaborator Author

closing due to moved content

@adamegyed adamegyed closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant