Skip to content

Conversation

Zer0dot
Copy link
Collaborator

@Zer0dot Zer0dot commented Apr 3, 2025

Pull Request Checklist


PR-Codex overview

This PR introduces new error classes for handling invalid deferred action modes and nonces, enhances the createModularAccountV2 function to support deferred actions, and updates various tests and documentation to accommodate these changes.

Detailed summary

  • Added InvalidDeferredActionMode and InvalidDeferredActionNonce error classes.
  • Updated createModularAccountV2 to accept deferredAction and handle related logic.
  • Modified singleSignerMessageSigner and nativeSMASigner to include deferredActionData.
  • Enhanced tests for deferred actions, including session key installations and ERC20 permissions.
  • Updated documentation for new error classes and their usage.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 9:41pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 9:41pm

Copy link
Contributor

graphite-app bot commented Apr 3, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@Zer0dot Zer0dot force-pushed the zer0dot/permissions-translation-layer branch from 40dc2bb to daa4926 Compare April 3, 2025 18:27
@Zer0dot Zer0dot marked this pull request as ready for review April 5, 2025 02:12
Zer0dot and others added 11 commits April 7, 2025 16:18
Co-authored-by: jakehobbs <jacob.hobbs@alchemy.com>
Co-authored-by: jakehobbs <jacob.hobbs@alchemy.com>
Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com>
Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com>
Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com>
@howydev howydev force-pushed the zer0dot/permissions-translation-layer branch from 220ed3e to 849e186 Compare April 7, 2025 20:18
howydev
howydev previously approved these changes Apr 7, 2025
@jakehobbs jakehobbs self-requested a review April 7, 2025 21:26
jakehobbs
jakehobbs previously approved these changes Apr 7, 2025
@howydev howydev merged commit e9ced74 into main Apr 7, 2025
8 checks passed
@howydev howydev deleted the zer0dot/permissions-translation-layer branch April 7, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants