-
Notifications
You must be signed in to change notification settings - Fork 197
refactor: cleanup and refactor permission builder errors #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
🌿 Documentation Preview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
b3a0633
to
ad34e25
Compare
eeb0c5b
to
15878d2
Compare
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)Also includes a minor fix where the permission builder was not adding the permission to the array with the ACCOUNT_FUNCTIONS permission, leading to potentially duplicating this + root permissions.
PR-Codex overview
This PR focuses on enhancing the
PermissionBuilder
functionality by introducing error handling for various permission-related issues and adding a new utility function,buildDeferredActionDigest
, to facilitate action digest creation.Detailed summary
buildDeferredActionDigest
function toutils.ts
for digest creation.permissionBuilderErrors.ts
for better error handling.PermissionBuilder
with specific error classes.permissionBuilderErrors.js
.buildDeferredActionDigest
instead ofprovider.buildDeferredActionDigest
.deferralActions.test.ts
.