Skip to content

Conversation

Zer0dot
Copy link
Collaborator

@Zer0dot Zer0dot commented Apr 8, 2025

Pull Request Checklist

Also includes a minor fix where the permission builder was not adding the permission to the array with the ACCOUNT_FUNCTIONS permission, leading to potentially duplicating this + root permissions.


PR-Codex overview

This PR focuses on enhancing the PermissionBuilder functionality by introducing error handling for various permission-related issues and adding a new utility function, buildDeferredActionDigest, to facilitate action digest creation.

Detailed summary

  • Added buildDeferredActionDigest function to utils.ts for digest creation.
  • Introduced error classes in permissionBuilderErrors.ts for better error handling.
  • Replaced error messages in PermissionBuilder with specific error classes.
  • Exported new error classes from permissionBuilderErrors.js.
  • Updated tests to use buildDeferredActionDigest instead of provider.buildDeferredActionDigest.
  • Added unit tests for new error handling scenarios in deferralActions.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 0:47am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 0:47am

Copy link
Contributor

graphite-app bot commented Apr 8, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

github-actions bot commented Apr 8, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Apr 9, 2025, 12:31 AM

howydev
howydev previously approved these changes Apr 8, 2025
Copy link
Contributor

@howydev howydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Zer0dot Zer0dot force-pushed the zer0dot/permission-builder-expanded-testing branch from b3a0633 to ad34e25 Compare April 8, 2025 22:13
howydev
howydev previously approved these changes Apr 8, 2025
@Zer0dot Zer0dot force-pushed the zer0dot/permission-builder-expanded-testing branch from eeb0c5b to 15878d2 Compare April 9, 2025 00:27
@github-actions github-actions bot temporarily deployed to docs-preview April 9, 2025 00:28 Inactive
@Zer0dot Zer0dot merged commit 243a3c0 into main Apr 9, 2025
8 checks passed
@Zer0dot Zer0dot deleted the zer0dot/permission-builder-expanded-testing branch April 9, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants