Skip to content

Conversation

@andysim3d
Copy link
Collaborator

@andysim3d andysim3d commented Apr 23, 2025

Pull Request Checklist

tested on chain:

With Permit:
https://sepolia.etherscan.io/tx/0x57fc8bae157a9b45068d45de503f3f841c5f15732c4e8bf47f1e3ee4e09d26b3

Without Permit:
https://sepolia.etherscan.io/tx/0xd0dc1b2f8ea6255db3e103eeca052598ff2b06f9cbb9e7a76bc9d4d064fdf85e


PR-Codex overview

This PR introduces enhancements to the handling of ERC20 tokens within the Alchemy Smart Account Client, adding support for policy tokens, permit types, and related middleware adjustments for gas management.

Detailed summary

  • Added erc20Context to types.ts for token management.
  • Introduced policyToken in smartAccountClient.ts for ERC20 token details.
  • Updated alchemyGasAndPaymasterAndDataMiddleware to handle policyToken.
  • Defined PermitTypes, EIP712NoncesAbi, PermitMessage, and PermitDomain in gas-manager.ts.
  • Enhanced middleware to manage ERC20 permits and gas requests.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 2:16pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 2:16pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 23, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@andysim3d andysim3d changed the title feat: add erc20Context to sdk [WIP] feat: add erc20Context to sdk Apr 23, 2025
@github-actions
Copy link

github-actions bot commented Apr 23, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Apr 29, 2025, 7:00 PM

@github-actions github-actions bot temporarily deployed to docs-preview April 29, 2025 18:53 Inactive
@andysim3d andysim3d force-pushed the andy/erc20-paymaster branch from 6dc70b9 to 4d8ed14 Compare April 29, 2025 18:54
@github-actions github-actions bot had a problem deploying to docs-preview April 29, 2025 18:54 Failure
@github-actions github-actions bot temporarily deployed to docs-preview April 29, 2025 18:57 Inactive
jakehobbs
jakehobbs previously approved these changes Apr 29, 2025
Copy link
Contributor

@jakehobbs jakehobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andysim3d andysim3d merged commit 56ddda0 into main Apr 30, 2025
7 of 8 checks passed
@andysim3d andysim3d deleted the andy/erc20-paymaster branch April 30, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants