-
Notifications
You must be signed in to change notification settings - Fork 199
fix: unify maxTokenAmount as token value #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🌿 Documentation Preview
|
dancoombs
reviewed
Jun 18, 2025
1840bd6 to
41c0abe
Compare
41c0abe to
c0aee93
Compare
7a85df9 to
dd3a94a
Compare
dd3a94a to
955860e
Compare
jakehobbs
reviewed
Jun 25, 2025
955860e to
7503a10
Compare
jakehobbs
previously approved these changes
Jun 25, 2025
7503a10 to
9deb94b
Compare
jakehobbs
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on updating the data types related to
maxTokenAmountfromBigInttonumberacross various files, enhancing consistency and usability. It also modifies descriptions in documentation to clarify the purpose of certain fields.Detailed summary
maxTokenAmounttype fromBigInttonumberin multiple files.maxTokenAmountincomponents.yamlto specify it refers to tokens.USDC_GAS_APPROVAL_AMOUNTconstant fromBigInttonumber.PolicyTokeninterface to usenumberformaxTokenAmount.maxTokenAmountin functions to reflect the new type.