feat: export wallet #1858
Merged
feat: export wallet #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🌿 Documentation Preview
|
androbwebb
changed the title
androbwebb
force-pushed
the
webb/rn-export
branch
from
cd79e2c to
70b038a
Compare
androbwebb
changed the title
androbwebb
requested review from
dancoombs,
dphilipson,
linnall,
adamegyed,
Zer0dot,
noam-alchemy,
jakehobbs,
avarobinson,
florrdv,
blakecduncan,
Shenghu-Yang,
andysim3d,
0xfourzerofour,
niveda-krish,
alex-miao,
thebrianchen and
joshzhang5
as code owners
androbwebb
commented
Sep 4, 2025
| SEED_PHRASE = "SEED_PHRASE", | ||
| } | ||
|
|
||
| export type ExportWalletParams = { |
There was a problem hiding this comment.
@florrdv making this type into a simple string (or the enum above) requires a larger refactor in the useWalletExport function too. I just didn't want to get into it
florrdv
reviewed
Sep 4, 2025
account-kit/rn-signer/src/client.ts
Outdated
Comment on lines
57
to
60
| export enum ExportWalletAs { | ||
| PRIVATE_KEY = "PRIVATE_KEY", | ||
| SEED_PHRASE = "SEED_PHRASE", | ||
| } |
There was a problem hiding this comment.
🌈 can we revert this to not be an enum? no need
account-kit/signer/src/base.ts
Outdated
| import { hashAuthorization } from "viem/utils"; | ||
|
|
||
| export interface BaseAlchemySignerParams<TClient extends BaseSignerClient> { | ||
| export interface BaseAlchemySignerParams< |
There was a problem hiding this comment.
florrdv
reviewed
Sep 4, 2025
account-kit/signer/src/base.ts
Outdated
| export abstract class BaseAlchemySigner<TClient extends BaseSignerClient> | ||
| implements SmartAccountAuthenticator<AuthParams, User, TClient> | ||
| export abstract class BaseAlchemySigner< | ||
| TClient extends BaseSignerClient<any, any>, |
florrdv
previously approved these changes
Sep 4, 2025
florrdv
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces significant changes to the wallet export functionality, transitioning from a boolean return type to a
Promise<unknown>, enhancing the export process with improved error handling and support for different export formats.Detailed summary
ExportWalletOutputtype asboolean.exportWalletmethods to returnPromise<unknown>.BaseSignerClientto handle different export types and outputs.RNSignerClientto support exporting both private keys and seed phrases.