-
Notifications
You must be signed in to change notification settings - Fork 197
feat: add http debug options to alchemyTransport #1944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌿 Documentation Preview
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fetchOptions?: NoUndefined<HttpTransportConfig["fetchOptions"]>; | ||
/** HTTP transport options for debugging and configuration */ | ||
httpOptions?: Pick< | ||
HttpTransportConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't the retry & fetch options part of this HttpTransportConfig
too in viem? do you think it's weird that we are picking some of these to be here, but others to be top level? curious to hear your thoughts.
Add viem's http options into
alchemyTransport
for easier debuggingPull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on enhancing the
alchemyTransport
functionality by adding HTTP debugging options and refining the configuration interface. It updates documentation and tests to reflect these changes, improving usability for developers.Detailed summary
onFetchRequest
andonFetchResponse
.timeout
parameter inalchemyTransport
.AlchemyTransportConfig
to extendHttpTransportConfig
.