Skip to content

Conversation

adamegyed
Copy link
Collaborator

@adamegyed adamegyed commented Aug 27, 2025

Pull Request Checklist


PR-Codex overview

This PR introduces the OptionalChainId type, allowing the chainId property to be optional in various API calls. This change enhances flexibility and backward compatibility by enabling API consumers to omit the chainId if desired.

Detailed summary

  • Renamed WithoutChainId<T> to OptionalChainId<T> in types.ts.
  • Updated multiple API parameter types to use OptionalChainId.
  • Modified API calls to support optional chainId, defaulting to toHex(client.chain.id) when not provided.
  • Added tests for overriding chainId in prepareCalls, sendPreparedCalls, and grantPermissions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
aa-sdk-ui-demo Ready Ready Preview Comment Aug 27, 2025 8:32pm

Copy link

github-actions bot commented Aug 27, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Aug 27, 2025, 8:30 PM

@github-actions github-actions bot temporarily deployed to docs-preview August 27, 2025 20:29 Inactive
@adamegyed adamegyed merged commit 988973a into moldy/v5-base Aug 27, 2025
8 checks passed
@adamegyed adamegyed deleted the adam/allow-chainid-override branch August 27, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants