Skip to content

Conversation

florrdv
Copy link
Contributor

@florrdv florrdv commented Aug 29, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on updating dependencies, enhancing configuration files, and making adjustments to the project structure for a React Native application.

Detailed summary

  • Updated react-native-config, @react-native-community/cli, and added @react-navigation/elements.
  • Enhanced metro.config.js to handle .js/.jsx extensions in TypeScript files.
  • Modified package.json dependencies, including updates to expo, react-native, and react-native-screens.
  • Updated Podfile.lock to reflect new versions for various pods.
  • Adjusted project.pbxproj to include new files and update existing ones.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
aa-sdk-ui-demo Ready Ready Preview Comment Sep 6, 2025 5:13am

Copy link
Contributor

graphite-app bot commented Aug 29, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

github-actions bot commented Aug 29, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Sep 6, 2025, 5:10 AM

@github-actions github-actions bot temporarily deployed to docs-preview August 29, 2025 22:05 Inactive
Comment on lines 70 to 78
onPress={() => {
signer
.authenticate({
phone,
type: "sms",
})
.catch(console.error);
setAwaitingOtp(true);
}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a potential race condition in the authentication flow. Currently, setAwaitingOtp(true) is executed immediately after initiating the async authenticate() call, without waiting for its completion. If the authentication request fails, the UI will still transition to the OTP input screen even though no OTP was actually sent.

Consider moving the state update inside a success callback or adding error handling to reset the state:

onPress={() => {
  signer
    .authenticate({
      phone,
      type: "sms",
    })
    .then(() => {
      setAwaitingOtp(true);
    })
    .catch((error) => {
      console.error(error);
      // Optionally show an error message to the user
    });
}}

This ensures the UI state accurately reflects the authentication process status.

Suggested change
onPress={() => {
signer
.authenticate({
phone,
type: "sms",
})
.catch(console.error);
setAwaitingOtp(true);
}}
onPress={() => {
signer
.authenticate({
phone,
type: "sms",
})
.then(() => {
setAwaitingOtp(true);
})
.catch((error) => {
console.error(error);
// Optionally show an error message to the user
});
}}

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@github-actions github-actions bot temporarily deployed to docs-preview August 29, 2025 22:08 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview August 29, 2025 22:20 Inactive
Richard-Dang
Richard-Dang previously approved these changes Sep 2, 2025
@github-actions github-actions bot temporarily deployed to docs-preview September 6, 2025 03:54 Inactive
@florrdv florrdv force-pushed the flor/feat/fix-expo-example branch from c12e792 to c88849a Compare September 6, 2025 03:55
@florrdv florrdv force-pushed the flor/feat/fix-expo-example branch from c88849a to 9016c1b Compare September 6, 2025 03:59
@github-actions github-actions bot temporarily deployed to docs-preview September 6, 2025 03:59 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview September 6, 2025 04:30 Inactive
@florrdv florrdv enabled auto-merge (squash) September 6, 2025 04:41
@github-actions github-actions bot temporarily deployed to docs-preview September 6, 2025 05:09 Inactive
@jakehobbs jakehobbs self-requested a review September 6, 2025 05:10
@florrdv florrdv merged commit d6161dd into main Sep 6, 2025
10 checks passed
@florrdv florrdv deleted the flor/feat/fix-expo-example branch September 6, 2025 05:15
Richard-Dang pushed a commit that referenced this pull request Sep 11, 2025
* feat: working version

* feat: working version

* chore: remove sms auth

* feat: regenerate with old lockfile, remove expo-doctor

* chore: update lockfile & remove embedded-accounts-quickstart

---------

Co-authored-by: jakehobbs <jacob.hobbs@alchemy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants