chore: remove account-kit refs in v5 #2123
Conversation
thebrianchen
requested review from
dancoombs,
dphilipson,
linnall,
adamegyed,
Zer0dot,
noam-alchemy,
jakehobbs,
avarobinson,
florrdv,
blakecduncan,
Shenghu-Yang,
andysim3d,
0xfourzerofour,
niveda-krish,
alex-miao,
joshzhang5,
AlvaroLuken,
Dan-Nolan,
SahilAujla and
Richard-Dang
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🌿 Documentation Preview
|
| initCode: await smartAccount.getInitCode(), | ||
| callData: await smartAccount.encodeBatchExecute([ | ||
| initCode: | ||
| factoryArgs.factory && factoryArgs.factoryData |
There was a problem hiding this comment.
i couldn't get this part to look clean, is there a simpler way? this is based on claude, but not sure if this correctly maps to init code. not sure where comes from now
There was a problem hiding this comment.
factory && factoryData ? concat([factory, factoryData]) : undefined is slightly nicer.
this is normally handled within prepareUserOperation w/ viem, but that also handles gas and paymaster data, so we can't really use it here.
| initCode: await smartAccount.getInitCode(), | ||
| callData: await smartAccount.encodeBatchExecute([ | ||
| initCode: | ||
| factoryArgs.factory && factoryArgs.factoryData |
There was a problem hiding this comment.
factory && factoryData ? concat([factory, factoryData]) : undefined is slightly nicer.
this is normally handled within prepareUserOperation w/ viem, but that also handles gas and paymaster data, so we can't really use it here.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on updating the
package.jsonscripts, modifying theAlchemyJsonRpcSchematype, and refactoring tests inrequestGasAndPaymasterAndData.test.tsto use new imports and structures from@alchemypackages, enhancing compatibility and organization.Detailed summary
package.jsonbuildandbuild:libsscripts.AlchemyJsonRpcSchematype to an empty array.createLightAccountwithtoLightAccountfrom@alchemy/smart-accounts.privateKeyToAccountandcreateWalletClient.getStubSignature()instead ofgetDummySignature().