chore: remove aa-sdk imports from v5 #2126
Open
+100
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebrianchen
requested review from
dancoombs,
dphilipson,
linnall,
adamegyed,
Zer0dot,
noam-alchemy,
jakehobbs,
avarobinson,
florrdv,
blakecduncan,
Shenghu-Yang,
andysim3d,
0xfourzerofour,
niveda-krish,
alex-miao,
joshzhang5,
AlvaroLuken,
Dan-Nolan,
SahilAujla and
Richard-Dang
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🌿 Documentation Preview
|
adamegyed
approved these changes
Sep 26, 2025
jakehobbs
approved these changes
Sep 26, 2025
| "build": "yarn build:libs --filter='!@account-kit/react-native-signer' --filter='!@account-kit/react-native-signer-example'", | ||
| "postbuild": "yarn lint:write", | ||
| "build:libs": "turbo run build --filter='@aa-sdk/*' --filter='./templates/*' --filter='./packages/*'", | ||
| "build:libs": "turbo run build --filter='./templates/*' --filter='./packages/*'", |
There was a problem hiding this comment.
nit: you could prob remove the build:v5 script that i added previously, if you want.
| import { getContract, type Address, type Hex, type Client } from "viem"; | ||
|
|
||
| /** | ||
| * Test utility functilln that computes the counterfactual address using the EntryPoint's getSenderAddress function. |
There was a problem hiding this comment.
nit: spelling
Suggested change
| * Test utility functilln that computes the counterfactual address using the EntryPoint's getSenderAddress function. | |
| * Test utility function that computes the counterfactual address using the EntryPoint's getSenderAddress function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR primarily focuses on removing the
splittransport functionality from the codebase and refactoring related components. It also introduces a new utility function for computing counterfactual addresses using the EntryPoint'sgetSenderAddress.Detailed summary
split.tsand related documentation.splitfromindex.tsandconnection.ts.AlchemyConnectionConfigtype to excludeSplitTransportParams.getAccountAddressViaEntryPointutility function intest-utils.predictAddress.test.tsandlight-account/predictAddress.test.tsto use the new utility function for address computation.