chore: test vercel CI do not merge #2133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebrianchen
requested review from
dancoombs,
dphilipson,
linnall,
adamegyed,
Zer0dot,
noam-alchemy,
jakehobbs,
avarobinson,
florrdv,
blakecduncan,
andysim3d,
0xfourzerofour,
niveda-krish,
alex-miao,
joshzhang5,
AlvaroLuken,
Dan-Nolan,
SahilAujla and
Richard-Dang
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR appears to be a test for Vercel CI infrastructure and should not be merged into production code, as indicated by the title. The change adds debugging code to the account-signer.ts file in the ethers package.
Key Changes
- Adds a console.log statement and comment for testing purposes
- Modifies production code in the ethers package
Comment on lines
+21
to
+22
| // dummy comment added | ||
| console.log("dummy comment added"); |
There was a problem hiding this comment.
This debugging code should not be committed to production. Remove the console.log statement and dummy comment before merging.
Suggested change
| // dummy comment added | |
| console.log("dummy comment added"); |
Copilot uses AI. Check for mistakes.
🌿 Documentation Preview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces a console log statement in
aa-sdk/ethers/src/account-signer.tsand updates the script inscripts/vercel-ignore-build.shto extract the base branch reference from the GitHub API response usinggrepandsedinstead ofjq.Detailed summary
aa-sdk/ethers/src/account-signer.ts.PR_BASEinscripts/vercel-ignore-build.shto usegrepandsedinstead ofjq.